Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-11 Thread Miles Chen
On Fri, 2017-11-10 at 10:02 -0600, Christopher Lameter wrote: > On Fri, 10 Nov 2017, Miles Chen wrote: > > > By checking disable_higher_order_debug & (slub_debug & > > SLAB_NEVER_MERGE), we can detect if a cache is unmergeable but become > > mergeable because the disable_higher_order_debug=1 logic

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-10 Thread Christopher Lameter
On Fri, 10 Nov 2017, Miles Chen wrote: > By checking disable_higher_order_debug & (slub_debug & > SLAB_NEVER_MERGE), we can detect if a cache is unmergeable but become > mergeable because the disable_higher_order_debug=1 logic. Those kind of > caches should be keep unmergeable. Acked-by: Christop

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-09 Thread Miles Chen
On Thu, 2017-11-09 at 09:49 -0600, Christopher Lameter wrote: > On Thu, 9 Nov 2017, Miles Chen wrote: > > > In this fix patch, it disables slab merging if SLUB_DEBUG=O and > > CONFIG_SLUB_DEBUG_ON=y but the debug features are disabled by the > > disable_higher_order_debug logic and it holds the "s

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-09 Thread Christopher Lameter
On Thu, 9 Nov 2017, Miles Chen wrote: > In this fix patch, it disables slab merging if SLUB_DEBUG=O and > CONFIG_SLUB_DEBUG_ON=y but the debug features are disabled by the > disable_higher_order_debug logic and it holds the "slab merging is off > if any debug features are enabled" behavior. Sound

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-09 Thread Miles Chen
On Wed, 2017-11-08 at 09:05 -0600, Christopher Lameter wrote: > On Wed, 8 Nov 2017, Miles Chen wrote: > > > > Ok then the aliasing failed for some reason. The creation of the unique id > > > and the alias detection needs to be in sync otherwise duplicate filenames > > > are created. What is the di

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-08 Thread Christopher Lameter
On Wed, 8 Nov 2017, Miles Chen wrote: > > Ok then the aliasing failed for some reason. The creation of the unique id > > and the alias detection needs to be in sync otherwise duplicate filenames > > are created. What is the difference there? > > The aliasing failed because find_mergeable() returns

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-07 Thread Miles Chen
On Tue, 2017-11-07 at 09:22 -0600, Christopher Lameter wrote: > On Tue, 7 Nov 2017, miles.c...@mediatek.com wrote: > > > When slub_debug=O is set. It is possible to clear debug flags > > for an "unmergeable" slab cache in kmem_cache_open(). > > It makes the "unmergeable" cache became "mergeable" i

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-07 Thread kbuild test robot
Hi Miles, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.14-rc8 next-20171107] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O

2017-11-07 Thread Christopher Lameter
On Tue, 7 Nov 2017, miles.c...@mediatek.com wrote: > When slub_debug=O is set. It is possible to clear debug flags > for an "unmergeable" slab cache in kmem_cache_open(). > It makes the "unmergeable" cache became "mergeable" in sysfs_slab_add(). Right but that is only if disable_higher_order_debu