Re: [PATCH] slub: fix confusing error messages in check_slab

2014-11-24 Thread David Rientjes
On Mon, 24 Nov 2014, Andrey Ryabinin wrote: > It's in -mm already > http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-fix-format-mismatches-in-slab_err-callers.patch > Yeah, and the one in -mm isn't whitespace damaged. Since the issue has existed for years, I don't think there's any rush in get

Re: [PATCH] slub: fix confusing error messages in check_slab

2014-11-24 Thread Andrey Ryabinin
2014-11-24 20:17 GMT+03:00 Christoph Lameter : > On Mon, 24 Nov 2014, Min-Hua Chen wrote: > >> In check_slab, s->name is passed incorrectly to the error >> messages. It will cause confusing error messages if the object >> check fails. This patch fix this bug by removing s->name. > > I have seen a p

Re: [PATCH] slub: fix confusing error messages in check_slab

2014-11-24 Thread Christoph Lameter
On Mon, 24 Nov 2014, Min-Hua Chen wrote: > In check_slab, s->name is passed incorrectly to the error > messages. It will cause confusing error messages if the object > check fails. This patch fix this bug by removing s->name. I have seen a patch like thios before. Acked-by: Christoph Lameter --