Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2013-01-09 Thread Casey Schaufler
On 11/8/2012 10:08 AM, Jarkko Sakkinen wrote: > SMACK_MAGIC moved to a proper place for easy user space access > (i.e. libsmack). > > Signed-off-by: Jarkko Sakkinen Applied to git://git.gitorious.org/smack-next/kernel.git#stage-for-3.9 > --- > include/uapi/linux/magic.h |1 + > security/sma

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-08 Thread Casey Schaufler
On 11/8/2012 10:08 AM, Jarkko Sakkinen wrote: > SMACK_MAGIC moved to a proper place for easy user space access > (i.e. libsmack). > > Signed-off-by: Jarkko Sakkinen I will apply once James updates the next branch of his security tree. > --- > include/uapi/linux/magic.h |1 + > security/smac

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-08 Thread Casey Schaufler
On 11/8/2012 7:04 AM, Eric Paris wrote: > Then it only works by accident that magic.h is included by some random > path in smackfs.c. You really should be including it in smack.h (or > each .c file individually, up to casey) I should think it should go in smack.h > On Thu, Nov 8, 2012 at 5:43 AM

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-08 Thread Jarkko Sakkinen
On Thu, Nov 8, 2012 at 7:40 PM, Casey Schaufler wrote: > On 11/8/2012 7:04 AM, Eric Paris wrote: >> Then it only works by accident that magic.h is included by some random >> path in smackfs.c. You really should be including it in smack.h (or >> each .c file individually, up to casey) > > I should

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-08 Thread Jarkko Sakkinen
On Thu, Nov 8, 2012 at 5:04 PM, Eric Paris wrote: > Then it only works by accident that magic.h is included by some random > path in smackfs.c. You really should be including it in smack.h (or > each .c file individually, up to casey) Fully agree. Just answered to the query :) > > On Thu, Nov 8

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-08 Thread Eric Paris
Then it only works by accident that magic.h is included by some random path in smackfs.c. You really should be including it in smack.h (or each .c file individually, up to casey) On Thu, Nov 8, 2012 at 5:43 AM, Jarkko Sakkinen wrote: > On Tue, Nov 6, 2012 at 11:59 PM, Casey Schaufler > wrote:

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-08 Thread Jarkko Sakkinen
On Tue, Nov 6, 2012 at 11:59 PM, Casey Schaufler wrote: > > On 11/6/2012 12:17 AM, Jarkko Sakkinen wrote: > > SMACK_MAGIC moved to a proper place for easy user space access > > (i.e. libsmack). > > > > Signed-off-by: Jarkko Sakkinen > > --- > > include/uapi/linux/magic.h |1 + > > security/s

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-06 Thread Eric Paris
It looks like smack_lsm.c includes linux/magic.h, but smackfs.c doesn't... Seems like they should have included linux/magic.h in the same header they removed the definition from On Tue, Nov 6, 2012 at 4:59 PM, Casey Schaufler wrote: > On 11/6/2012 12:17 AM, Jarkko Sakkinen wrote: >> SMACK_M

Re: [PATCH] smack: SMACK_MAGIC to include/uapi/linux/magic.h

2012-11-06 Thread Casey Schaufler
On 11/6/2012 12:17 AM, Jarkko Sakkinen wrote: > SMACK_MAGIC moved to a proper place for easy user space access > (i.e. libsmack). > > Signed-off-by: Jarkko Sakkinen > --- > include/uapi/linux/magic.h |1 + > security/smack/smack.h |5 - > 2 files changed, 1 insertion(+), 5 deletio