Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-08 Thread Luca Tettamanti
Yoann Padioleau <[EMAIL PROTECTED]> ha scritto: > > Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc). [...] > diff --git a/arch/alpha/kernel/module.c b/arch/alpha/kernel/module.c > index bd03dc9..026ba9a 100644 > --- a/arch/alpha/kernel/module.c > +++ b/arch/alpha/kernel/mod

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-07 Thread Tilman Schmidt
Am 07.07.2007 15:36 schrieb yoann padioleau: > On 7 juil. 07, at 15:07, Tilman Schmidt wrote: > >> This misses the semantic distinction between the first and second >> arguments of kcalloc(). The first argument is supposed to be the >> number of elements to allocate and the second their size. As a

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-07 Thread Jan Engelhardt
On Jul 6 2007 18:51, Yoann Padioleau wrote: >Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc). > >Here is a short excerpt of the semantic patch performing >this transformation: Cool! >--- a/Documentation/connector/cn_test.c >+++ b/Documentation/connector/cn_test.c >@@ -12

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-07 Thread yoann padioleau
On 7 juil. 07, at 15:07, Tilman Schmidt wrote: Am 06.07.2007 18:51 schrieb Yoann Padioleau: @@ expression E1,E2,E3; @@ - kzalloc(E1 * E2,E3) + kcalloc(E1,E2,E3) This misses the semantic distinction between the first and second arguments of kcalloc(). The first argument is supposed to be the

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-07 Thread Tilman Schmidt
Am 06.07.2007 18:51 schrieb Yoann Padioleau: > @@ > expression E1,E2,E3; > @@ > > - kzalloc(E1 * E2,E3) > + kcalloc(E1,E2,E3) This misses the semantic distinction between the first and second arguments of kcalloc(). The first argument is supposed to be the number of elements to allocate and the s

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-06 Thread Andrew Morton
On Fri, 6 Jul 2007 18:07:20 -0400 (EDT) James Morris <[EMAIL PROTECTED]> wrote: > On Fri, 6 Jul 2007, Heikki Orsila wrote: > > > > Transform some calls to kmalloc/memset to a single kzalloc (or > > > kcalloc). > > > > I looked all the files through. They looked good to me, except > > one case:

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-06 Thread James Morris
On Fri, 6 Jul 2007, Heikki Orsila wrote: > > Transform some calls to kmalloc/memset to a single kzalloc (or > > kcalloc). > > I looked all the files through. They looked good to me, except > one case: I checked the drivers/net and net/ changes and they looked ok (aside from the above). - Ja

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-06 Thread Heikki Orsila
> Transform some calls to kmalloc/memset to a single kzalloc (or > kcalloc). I looked all the files through. They looked good to me, except one case: In drivers/net/hamradio/dmascc.c you removed one comment, and I think it should not be removed: /* Initialize what is necessary for write_scc a

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-06 Thread Christoph Lameter
On Fri, 6 Jul 2007, Peter Zijlstra wrote: > On Fri, 2007-07-06 at 18:51 +0200, Yoann Padioleau wrote: > > Transform some calls to kmalloc/memset to a single kzalloc (or > > kcalloc). > > > > Christoph, what is the plan wrt GFP_ZERO? Its going in AFAIK. Need to resort my patches and then I will

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-06 Thread Peter Zijlstra
On Fri, 2007-07-06 at 18:51 +0200, Yoann Padioleau wrote: > Transform some calls to kmalloc/memset to a single kzalloc (or > kcalloc). > Christoph, what is the plan wrt GFP_ZERO? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE