Re: [PATCH] sound: pci: ctxfi: ctatc.c: printk replacement

2014-08-26 Thread Takashi Iwai
At Tue, 26 Aug 2014 13:21:00 +0530, Sudip Mukherjee wrote: > > On Tue, Aug 26, 2014 at 08:27:09AM +0200, Takashi Iwai wrote: > > At Mon, 25 Aug 2014 23:26:52 +0530, > > Sudip Mukherjee wrote: > > > > > > printk replaced ith corresponding pr_err > > > fixed three broken user-visible strings > > >

Re: [PATCH] sound: pci: ctxfi: ctatc.c: printk replacement

2014-08-26 Thread Sudip Mukherjee
On Tue, Aug 26, 2014 at 08:27:09AM +0200, Takashi Iwai wrote: > At Mon, 25 Aug 2014 23:26:52 +0530, > Sudip Mukherjee wrote: > > > > printk replaced ith corresponding pr_err > > fixed three broken user-visible strings > > fixed a checkpatch warning of space before new line > > Fixes are good, but

Re: [PATCH] sound: pci: ctxfi: ctatc.c: printk replacement

2014-08-25 Thread Takashi Iwai
At Mon, 25 Aug 2014 23:26:52 +0530, Sudip Mukherjee wrote: > > printk replaced ith corresponding pr_err > fixed three broken user-visible strings > fixed a checkpatch warning of space before new line Fixes are good, but is this the final patch for ctxfi? If you're going to post another one, pleas