Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-04 Thread Mark Brown
On Fri, Dec 04, 2020 at 10:13:52AM +0100, Enric Balletbo i Serra wrote: > I am fine either way. I'm fine with pick all the patches and go through the > chrome/platform tree if Mark is agree (I think this patch has no other > dependencies and the patch applies cleanly to my tree) or all can go thro

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-04 Thread Enric Balletbo i Serra
Hi, On 4/12/20 1:10, Stephen Boyd wrote: > Quoting Doug Anderson (2020-12-03 12:06:10) >> On Wed, Dec 2, 2020 at 4:47 PM Stephen Boyd wrote: >>> >>> And that is wrong. With even more investigation and Doug's eagle eyes it >>> seems that the cros-ec driver is overriding the spi::mode to clear out

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-03 Thread Stephen Boyd
Quoting Doug Anderson (2020-12-03 12:06:10) > On Wed, Dec 2, 2020 at 4:47 PM Stephen Boyd wrote: > > > > And that is wrong. With even more investigation and Doug's eagle eyes it > > seems that the cros-ec driver is overriding the spi::mode to clear out > > the SPI_CS_HIGH bit that the spi core set

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-03 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 4:47 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2020-12-02 15:28:45) > > Quoting Alexandru M Stan (2020-12-02 14:18:20) > > > Unfortunately this patch makes my cros-ec (the main EC that used to > > > work even before my debugging) also fail to probe: > > > [0.

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-02 Thread Stephen Boyd
Quoting Stephen Boyd (2020-12-02 15:28:45) > Quoting Alexandru M Stan (2020-12-02 14:18:20) > > Unfortunately this patch makes my cros-ec (the main EC that used to > > work even before my debugging) also fail to probe: > > [0.839533] cros-ec-spi spi6.0: EC failed to respond in time > > [1.0

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-02 Thread Stephen Boyd
Quoting Alexandru M Stan (2020-12-02 14:18:20) > On Wed, Dec 2, 2020 at 1:49 PM Stephen Boyd wrote: > > > > Let's set the 'use_gpio_descriptors' field so that we use the new way of > > requesting the CS GPIOs in the core. This allows us to avoid having to > > configure the CS pins in "output" mode

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-02 Thread Alexandru M Stan
On Wed, Dec 2, 2020 at 1:49 PM Stephen Boyd wrote: > > Let's set the 'use_gpio_descriptors' field so that we use the new way of > requesting the CS GPIOs in the core. This allows us to avoid having to > configure the CS pins in "output" mode with an 'output-enable' pinctrl > setting. > > Cc: Akash