Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Ankit Gupta
> On 05/18/15 14:51, Ankit Gupta wrote: >> Add tracepoints to retrieve information about read, write >> and non-data commands. For performance measurement support >> tracepoints are added at the beginning and at the end of >> transfers. Following is a list showing the new tracepoint >> events. The

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Ankit Gupta
> On 05/20, Ankit Gupta wrote: >> On Tue, 19 May 2015 17:36:41 -0700 >> Stephen Boyd wrote: >> > On 05/18/15 14:51, Ankit Gupta wrote: >> > > + >> > > +TRACE_EVENT(spmi_read_end, >> > > +TP_PROTO(u8 opcode, u8 sid, u16 addr, int ret, u8 len, >> > >> > Should "len" be size_t instead of u8?

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Stephen Boyd
On 05/18/15 14:51, Ankit Gupta wrote: > Add tracepoints to retrieve information about read, write > and non-data commands. For performance measurement support > tracepoints are added at the beginning and at the end of > transfers. Following is a list showing the new tracepoint > events. The "cmd" p

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Stephen Boyd
On 05/20/15 11:58, Steven Rostedt wrote: > On Wed, 20 May 2015 11:29:55 -0700 > Stephen Boyd wrote: > > >>> I see no reason to spend to 4-8 bytes when spmi spec allows for maximum >>> buffer size of 16. Do you suggest changing the API of read_cmd()? >> Is that a maximum buffer size of 16 bytes? I'

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-20 Thread Steven Rostedt
On Wed, 20 May 2015 11:29:55 -0700 Stephen Boyd wrote: > > I see no reason to spend to 4-8 bytes when spmi spec allows for maximum > > buffer size of 16. Do you suggest changing the API of read_cmd()? > > > > > Is that a maximum buffer size of 16 bytes? I'd prefer consistency > with the API th

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-20 Thread Stephen Boyd
On 05/20, Ankit Gupta wrote: > On Tue, 19 May 2015 17:36:41 -0700 > Stephen Boyd wrote: > > On 05/18/15 14:51, Ankit Gupta wrote: > > > + > > > +TRACE_EVENT(spmi_read_end, > > > + TP_PROTO(u8 opcode, u8 sid, u16 addr, int ret, u8 len, > > > > Should "len" be size_t instead of u8? It would at leas

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-20 Thread Ankit Gupta
On Tue, 19 May 2015 17:36:41 -0700 Stephen Boyd wrote: > +Steven Rostedt > > On 05/18/15 14:51, Ankit Gupta wrote: > > Add tracepoints to retrieve information about read, write > > and non-data commands. For performance measurement support > > tracepoints are added at the beginning and at the en

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-19 Thread Steven Rostedt
On Tue, 19 May 2015 17:36:41 -0700 Stephen Boyd wrote: > +Steven Rostedt > > On 05/18/15 14:51, Ankit Gupta wrote: > > Add tracepoints to retrieve information about read, write > > and non-data commands. For performance measurement support > > tracepoints are added at the beginning and at the en

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-19 Thread Stephen Boyd
+Steven Rostedt On 05/18/15 14:51, Ankit Gupta wrote: > Add tracepoints to retrieve information about read, write > and non-data commands. For performance measurement support > tracepoints are added at the beginning and at the end of > transfers. Following is a list showing the new tracepoint > ev