Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Chen Gang
On 07/25/2014 11:39 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 11:34 PM, Chen Gang wrote: >> >> >> On 07/25/2014 11:30 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang >>> wrote: On 07/25/2014 11:13 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 11:34 PM, Chen Gang wrote: > > > On 07/25/2014 11:30 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 11:13 AM, Nick Krause wrote: On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: > > > On 07/2

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Chen Gang
On 07/25/2014 11:30 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: >> >> >> On 07/25/2014 11:13 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang >>> wrote: On 07/25/2014 10:53 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: > > > On 07/25/2014 11:13 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 10:53 AM, Nick Krause wrote: On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: > > > On 07/2

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Chen Gang
On 07/25/2014 11:13 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: >> >> >> On 07/25/2014 10:53 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang >>> wrote: On 07/25/2014 10:20 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: > > > On 07/25/2014 10:53 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 10:20 AM, Nick Krause wrote: On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: > > Excuse me, I

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Chen Gang
On 07/25/2014 10:53 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: >> >> >> On 07/25/2014 10:20 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang >>> wrote: Excuse me, I did not see the patch details, but I guess it is about whet

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: > > > On 07/25/2014 10:20 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: >>> >>> Excuse me, I did not see the patch details, but I guess it is about >>> whether welcome a new member to upstream kernel. For me, I have

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Chen Gang
On 07/25/2014 10:20 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: >> >> Excuse me, I did not see the patch details, but I guess it is about >> whether welcome a new member to upstream kernel. For me, I have 3 ideas >> about it if I am a newbie or a normal kernel dev

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: > > Excuse me, I did not see the patch details, but I guess it is about > whether welcome a new member to upstream kernel. For me, I have 3 ideas > about it if I am a newbie or a normal kernel developer: > > - Do I have enough basic skills for it

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Chen Gang
Excuse me, I did not see the patch details, but I guess it is about whether welcome a new member to upstream kernel. For me, I have 3 ideas about it if I am a newbie or a normal kernel developer: - Do I have enough basic skills for it? - Do I developed one or more another real world project

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Richard Weinberger
Am 24.07.2014 21:05, schrieb Nick Krause: > On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger >> wrote: >>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: Steve, I have programming a lot in other areas just not the kernel. >

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger > wrote: >> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >>> Steve, >>> I have programming a lot in other areas just not the kernel. >>> You are right through I need to test my code b

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger wrote: > On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >> Steve, >> I have programming a lot in other areas just not the kernel. >> You are right through I need to test my code better through. > > Nick, > > let's make a deal. > Take the ch

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Richard Weinberger
On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: > Steve, > I have programming a lot in other areas just not the kernel. > You are right through I need to test my code better through. Nick, let's make a deal. Take the challenge at http://eudyptula-challenge.org. After you've solved all tasks

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 1:48 PM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 10:30:51 -0700 > Harvey Harrison wrote: > >> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: >> > On Thu, 24 Jul 2014 12:50:31 -0400 >> > Nick Krause wrote: >> >> > >> >> I am have this discussion with other ke

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Steven Rostedt
On Thu, 24 Jul 2014 10:30:51 -0700 Harvey Harrison wrote: > On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > > On Thu, 24 Jul 2014 12:50:31 -0400 > > Nick Krause wrote: > > > > >> I am have this discussion with other kernel developers and just > >> because I send out one patch as a ne

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Harvey Harrison
On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 12:50:31 -0400 > Nick Krause wrote: > >> I am have this discussion with other kernel developers and just >> because I send out one patch as a newbie like this doesn't mean I >> don't known C. > > It's not just one patc

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Steven Rostedt
On Thu, 24 Jul 2014 12:50:31 -0400 Nick Krause wrote: \ > > Most kernel devs most certainly did NOT get started by spamming lkml > > with unnecessary and incorrect patches despite being repeatedly told to > > go away and stop wasting everybody's time. Mans, shut up! That is uncalled for. > > >

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 12:47 PM, Måns Rullgård wrote: > Nick Krause writes: > >> On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: >>> Nick Krause writes: >>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: > Steven Rostedt writes: > >> On Thu, 24 Jul 2014 10:47:

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
Nick Krause writes: > On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: >> Nick Krause writes: >> >>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: Steven Rostedt writes: > On Thu, 24 Jul 2014 10:47:25 -0400 > Steven Rostedt wrote: > >> The three param

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: > Nick Krause writes: > >> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >>> Steven Rostedt writes: >>> On Thu, 24 Jul 2014 10:47:25 -0400 Steven Rostedt wrote: > The three parameters are the number of elements,

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
Nick Krause writes: > On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >> Steven Rostedt writes: >> >>> On Thu, 24 Jul 2014 10:47:25 -0400 >>> Steven Rostedt wrote: >>> The three parameters are the number of elements, the size of each individual element, and then finally

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: > Steven Rostedt writes: > >> On Thu, 24 Jul 2014 10:47:25 -0400 >> Steven Rostedt wrote: >> >>> The three parameters are the number of elements, the size of each individual >>> element, and then finally the flags used on how to allocate tha

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
Steven Rostedt writes: > On Thu, 24 Jul 2014 10:47:25 -0400 > Steven Rostedt wrote: > >> The three parameters are the number of elements, the size of each individual >> element, and then finally the flags used on how to allocate that memory. >> I have to say, you did get the flags part correct.

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Steven Rostedt
On Thu, 24 Jul 2014 10:47:25 -0400 Steven Rostedt wrote: > The three parameters are the number of elements, the size of each individual > element, and then finally the flags used on how to allocate that memory. > I have to say, you did get the flags part correct. > > Now lets look at what you

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Steven Rostedt
On Wed, Jul 23, 2014 at 07:03:01PM -0400, Nicholas Krause wrote: > This changes the call to kzalloc to kcalloc in ion_dummy_driver > for allocating the heap. > > Signed-off-by: Nicholas Krause > --- > drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-23 Thread Richard Weinberger
On Thu, Jul 24, 2014 at 1:03 AM, Nicholas Krause wrote: > This changes the call to kzalloc to kcalloc in ion_dummy_driver > for allocating the heap. > > Signed-off-by: Nicholas Krause > --- > drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-23 Thread David Rientjes
On Wed, 23 Jul 2014, Nicholas Krause wrote: > diff --git a/drivers/staging/android/ion/ion_dummy_driver.c > b/drivers/staging/android/ion/ion_dummy_driver.c > index 3a45e79..8883432 100644 > --- a/drivers/staging/android/ion/ion_dummy_driver.c > +++ b/drivers/staging/android/ion/ion_dummy_driver.