Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-13 Thread Suthikulpanit, Suravee
Oren On 3/13/19 8:05 PM, Oren Twaig wrote: > Hi Suravee, > > Turns out, the _same_ bug was already discussed in the past by > yourself, Paolo and Radim (both now 'cc'-ed) > > Please read it here: > https://patchwork.kernel.org/patch/8292231/ > > > After reading that thread, I have couple of qu

Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-13 Thread Oren Twaig
Hi Suravee, Turns out, the _same_ bug was already discussed in the past by yourself, Paolo and Radim (both now 'cc'-ed) Please read it here: https://patchwork.kernel.org/patch/8292231/ After reading that thread, I have couple of questions: First, You wrote : "I have tried NOT setting the IRR

Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-13 Thread Oren Twaig
Hi Suravee, Please see below.. On 03/11/2019 01:38 PM, Suthikulpanit, Suravee wrote: Hi Oren, Sorry for delay response. On 3/5/19 1:15 AM, Oren Twaig wrote: Hello Suravee, According to AMD's SDM, the target-not-running incomplete ipi exit is only received if any of the destination cpus had

Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-12 Thread Suthikulpanit, Suravee
Oren, On 3/11/19 6:38 PM, Suthikulpanit, Suravee wrote: > However, looking a bit more closely, I notice the logic in > svm_deliver_avic_intr() > should also have been changed from kvm_vcpu_wake_up() to kvm_vcpu_kick() > since the latter will result in clearing the IRR bit for the IPI vector > whe

Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-11 Thread Suthikulpanit, Suravee
Hi Oren, Sorry for delay response. On 3/5/19 1:15 AM, Oren Twaig wrote: > Hello Suravee, > > According to AMD's SDM, the target-not-running incomplete > ipi exit is only received if any of the destination cpus had the > not-running bit set in the avic backing page. I believe you are referring t

Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-08 Thread Oren Twaig
Hi, Any help appreciated.. Thanks, Oren Twaig On 3/4/2019 8:15 PM, Oren Twaig wrote: Hello Suravee, According to AMD's SDM, the target-not-running incomplete ipi exit is only received if any of the destination cpus had the not-running bit set in the avic backing page. However, not before

re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-04 Thread Oren Twaig
Hello Suravee, According to AMD's SDM, the target-not-running incomplete ipi exit is only received if any of the destination cpus had the not-running bit set in the avic backing page. However, not before the CPU _already_ set the relevant IRR bit in all these cpus. In this change, the patch f

Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-01-25 Thread Paolo Bonzini
On 22/01/19 11:25, Suthikulpanit, Suravee wrote: > From: Suravee Suthikulpanit > > In case of incomplete IPI with invalid interrupt type, the current > SVM driver does not properly emulate the IPI, and fails to boot > FreeBSD guests with multiple vcpus when enabling AVIC. > > Fix this by update