Re: [PATCH] tc: fix warning and coding style

2014-09-30 Thread Maciej W. Rozycki
On Tue, 30 Sep 2014, Thibaut Robert wrote: > Fix checkpatch warnings: > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then > dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > WARNING: Possible unnecessary 'out of memory' message > WARNING: quoted string split across line

Re: [PATCH] tc: fix warning and coding style

2014-09-30 Thread Thibaut Robert
Le mardi 30 septembre 2014 à 16:08 +0200, Geert Uytterhoeven a écrit : > I guess that's acceptable, as tc is probably limited to 32-bit anyway. Maciej? > > Note that there's also %pa, for phys_addr_t/resource_size_t. Yes, but unfortunately that needs a reference so we can't use it. Thibaut -- To

Re: [PATCH] tc: fix warning and coding style

2014-09-30 Thread Geert Uytterhoeven
Hi Thibaut, On Tue, Sep 30, 2014 at 3:51 PM, Thibaut Robert wrote: > Le mardi 30 septembre 2014 à 14:28 +0200, Geert Uytterhoeven a écrit : >> On Tue, Sep 30, 2014 at 2:16 PM, Thibaut Robert >> wrote: >> > Fix gcc warning: >> > warning: format ‘%d’ expects argument of type ‘int’, but argument 4

Re: [PATCH] tc: fix warning and coding style

2014-09-30 Thread Thibaut Robert
Hi Geert, Le mardi 30 septembre 2014 à 14:28 +0200, Geert Uytterhoeven a écrit : > Hi Thibaut, > > On Tue, Sep 30, 2014 at 2:16 PM, Thibaut Robert > wrote: > > Fix gcc warning: > > warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has > > type ‘resource_size_t’ [-Wformat=] > >

Re: [PATCH] tc: fix warning and coding style

2014-09-30 Thread Geert Uytterhoeven
Hi Thibaut, On Tue, Sep 30, 2014 at 2:16 PM, Thibaut Robert wrote: > Fix gcc warning: > warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type > ‘resource_size_t’ [-Wformat=] > > As resource_size_t can be 32 or 64 bits (depending on > CONFIG_RESOURCES_64BIT), this patch us