Re: [PATCH] tcp: fix setting csum_start in tcp_gso_segment

2014-06-25 Thread David Miller
From: Dave Jones Date: Wed, 25 Jun 2014 10:10:52 -0400 > On Tue, Jun 24, 2014 at 09:17:25PM -0700, Linus Torvalds wrote: > > On Tue, Jun 24, 2014 at 9:03 PM, Tom Herbert wrote: > > > > > > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is > > > not set correctly when doing n

Re: [PATCH] tcp: fix setting csum_start in tcp_gso_segment

2014-06-25 Thread Dave Jones
On Tue, Jun 24, 2014 at 09:17:25PM -0700, Linus Torvalds wrote: > On Tue, Jun 24, 2014 at 9:03 PM, Tom Herbert wrote: > > > > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is > > not set correctly when doing non-scatter gather. We are using > > offset as opposed to doffset.

Re: [PATCH] tcp: fix setting csum_start in tcp_gso_segment

2014-06-25 Thread Eric Dumazet
On Tue, 2014-06-24 at 21:03 -0700, Tom Herbert wrote: > > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is > not set correctly when doing non-scatter gather. We are using > offset as opposed to doffset. > > Reported-by: Dave Jones > Signed-off-by: Tom Herbert > --- > net/cor

Re: [PATCH] tcp: fix setting csum_start in tcp_gso_segment

2014-06-24 Thread Linus Torvalds
On Tue, Jun 24, 2014 at 9:03 PM, Tom Herbert wrote: > > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is > not set correctly when doing non-scatter gather. We are using > offset as opposed to doffset. > > Reported-by: Dave Jones DaveJ, I think you triggered this in five minutes