Re: [PATCH] tegra-hsp: fix a missing-check bug in tegra_hsp_doorbell_create()

2019-06-17 Thread Gen Zhang
On Sun, Jun 09, 2019 at 12:11:44AM +0800, Gen Zhang wrote: > On Thu, May 30, 2019 at 09:19:20AM +0800, Gen Zhang wrote: > > In tegra_hsp_doorbell_create(), 'db->name' is allocated by > > devm_kstrdup_const(). It returns NULL when fails. So 'db->name' should > > be checked. > > > > Signed-off-by:

Re: [PATCH] tegra-hsp: fix a missing-check bug in tegra_hsp_doorbell_create()

2019-06-08 Thread Gen Zhang
On Thu, May 30, 2019 at 09:19:20AM +0800, Gen Zhang wrote: > In tegra_hsp_doorbell_create(), 'db->name' is allocated by > devm_kstrdup_const(). It returns NULL when fails. So 'db->name' should > be checked. > > Signed-off-by: Gen Zhang > Acked-by: Thierry Reding > --- > diff --git a/drivers/mai

Re: [PATCH] tegra-hsp: fix a missing-check bug in tegra_hsp_doorbell_create()

2019-05-27 Thread Gen Zhang
On Mon, May 27, 2019 at 04:05:49PM +0200, Thierry Reding wrote: > On Mon, May 27, 2019 at 09:04:30PM +0800, Gen Zhang wrote: > > In tegra_hsp_doorbell_create(), 'db->name' is allocated by > > devm_kstrdup_const(). It returns NULL when fails. So 'db->name' should > > be checked. > > > > Signed-off

Re: [PATCH] tegra-hsp: fix a missing-check bug in tegra_hsp_doorbell_create()

2019-05-27 Thread Thierry Reding
On Mon, May 27, 2019 at 09:04:30PM +0800, Gen Zhang wrote: > In tegra_hsp_doorbell_create(), 'db->name' is allocated by > devm_kstrdup_const(). It returns NULL when fails. So 'db->name' should > be checked. > > Signed-off-by: Gen Zhang > --- > diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/m