Re: [Linux-Xtensa] Re: [PATCH] time: sched_clock: fix integer overflow

2013-08-11 Thread Baruch Siach
Hi Thomas, John, On Mon, Jul 29, 2013 at 08:59:39AM +0300, Baruch Siach wrote: > On Wed, Jul 17, 2013 at 12:46:53PM +0300, Baruch Siach wrote: > > The expression '(1 << 32)' happens to evaluate as 0 on ARM, but it > > evaluates as > > 1 on xtensa and x86_64. This zeros sched_clock_mask, and break

Re: [PATCH] time: sched_clock: fix integer overflow

2013-07-29 Thread Stephen Boyd
On 07/28/13 22:59, Baruch Siach wrote: > Hi Thomas, John, > > On Wed, Jul 17, 2013 at 12:46:53PM +0300, Baruch Siach wrote: >> The expression '(1 << 32)' happens to evaluate as 0 on ARM, but it evaluates >> as >> 1 on xtensa and x86_64. This zeros sched_clock_mask, and breaks >> sched_clock(). >>

Re: [PATCH] time: sched_clock: fix integer overflow

2013-07-28 Thread Baruch Siach
Hi Thomas, John, On Wed, Jul 17, 2013 at 12:46:53PM +0300, Baruch Siach wrote: > The expression '(1 << 32)' happens to evaluate as 0 on ARM, but it evaluates > as > 1 on xtensa and x86_64. This zeros sched_clock_mask, and breaks sched_clock(). > Set the type of 1 to 'unsigned long long' to get th