Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename

2015-09-01 Thread Steven Rostedt
On Tue, 01 Sep 2015 11:07:32 -0400 Sasha Levin wrote: > > Also, as the memcpy was just faster than a strcpy, the static length > > was used. Perhaps we should convert that to a dynamic length string. > > But that should be a separate patch as this one fixes a possible bug, > > and the conversio

Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename

2015-09-01 Thread Sasha Levin
On 08/28/2015 11:02 AM, Steven Rostedt wrote: > On Fri, 28 Aug 2015 07:06:58 -0400 > Sasha Levin wrote: > >> While the dest comm string size is assured to be at least TASK_COMM_LEN long, >> doing a memcpy() also adds the assumption that the source is at least that >> long as well, which isn't ass

Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename

2015-08-28 Thread Steven Rostedt
On Fri, 28 Aug 2015 07:06:58 -0400 Sasha Levin wrote: > While the dest comm string size is assured to be at least TASK_COMM_LEN long, > doing a memcpy() also adds the assumption that the source is at least that > long as well, which isn't assured, and isn't true in cases such as: > > set_t