Re: [PATCH] udf: prevent memory leak in udf_new_inode

2019-09-26 Thread Navid Emamdoost
On Thu, Sep 26, 2019 at 10:00:31AM +0200, Jan Kara wrote: > On Wed 25-09-19 23:24:08, Al Viro wrote: > > On Wed, Sep 25, 2019 at 04:39:03PM -0500, Navid Emamdoost wrote: > > > In udf_new_inode if either udf_new_block or insert_inode_locked fials > > > the allocated memory for iinfo->i_ext.i_data sh

Re: [PATCH] udf: prevent memory leak in udf_new_inode

2019-09-26 Thread Jan Kara
On Wed 25-09-19 23:24:08, Al Viro wrote: > On Wed, Sep 25, 2019 at 04:39:03PM -0500, Navid Emamdoost wrote: > > In udf_new_inode if either udf_new_block or insert_inode_locked fials > > the allocated memory for iinfo->i_ext.i_data should be released. > > "... because of such-and-such reasons" part

Re: [PATCH] udf: prevent memory leak in udf_new_inode

2019-09-25 Thread Al Viro
On Wed, Sep 25, 2019 at 04:39:03PM -0500, Navid Emamdoost wrote: > In udf_new_inode if either udf_new_block or insert_inode_locked fials > the allocated memory for iinfo->i_ext.i_data should be released. "... because of such-and-such reasons" part appears to be missing. Why should it be released t