Re: Re: [PATCH] uprobes/x86: Refuse to attach uprobe to "word-sized" branch insns

2014-04-24 Thread Masami Hiramatsu
(2014/04/25 2:33), Oleg Nesterov wrote: > Thanks! > > Masami, Jim, any acks? > > On 04/24, Denys Vlasenko wrote: >> >> All branch insns on x86 can be prefixed with the operand-size >> override prefix, 0x66. It was only ever useful for performing >> jumps to 32-bit offsets in 16-bit code segments.

Re: [PATCH] uprobes/x86: Refuse to attach uprobe to "word-sized" branch insns

2014-04-24 Thread Jim Keniston
On Thu, 2014-04-24 at 19:33 +0200, Oleg Nesterov wrote: > Thanks! > > Masami, Jim, any acks? Acked-by: Jim Keniston > > On 04/24, Denys Vlasenko wrote: > > > > All branch insns on x86 can be prefixed with the operand-size > > override prefix, 0x66. It was only ever useful for performing > > ju

Re: [PATCH] uprobes/x86: Refuse to attach uprobe to "word-sized" branch insns

2014-04-24 Thread Oleg Nesterov
Thanks! Masami, Jim, any acks? On 04/24, Denys Vlasenko wrote: > > All branch insns on x86 can be prefixed with the operand-size > override prefix, 0x66. It was only ever useful for performing > jumps to 32-bit offsets in 16-bit code segments. > > In 32-bit code, such instructions are useless sin