Re: [PATCH] uprobes/x86: fix rip-relative handling of EVEX-encoded insns.

2016-08-12 Thread Denys Vlasenko
On 08/12/2016 07:39 AM, Srikar Dronamraju wrote: * Denys Vlasenko [2016-08-11 17:45:21]: Since instruction decoder now supports EVEX-encoded insns, two fixes are needed to correctly handle them in uprobes. Could you please add the commit that helps support the insns in the Changelog. Sorry

Re: [PATCH] uprobes/x86: fix rip-relative handling of EVEX-encoded insns.

2016-08-11 Thread Srikar Dronamraju
* Denys Vlasenko [2016-08-11 17:45:21]: > Since instruction decoder now supports EVEX-encoded insns, two fixes are > needed > to correctly handle them in uprobes. Could you please add the commit that helps support the insns in the Changelog. Rest all looks okay. Looks good to me. Acked-by:

Re: [PATCH] uprobes/x86: fix rip-relative handling of EVEX-encoded insns.

2016-08-11 Thread Masami Hiramatsu
On Thu, 11 Aug 2016 17:45:21 +0200 Denys Vlasenko wrote: > Since instruction decoder now supports EVEX-encoded insns, two fixes are > needed > to correctly handle them in uprobes. > > Extended bits for MODRM.rm field need to be sanitized just like we do it > for VEX3, to avoid encoding wrong re

Re: [PATCH] uprobes/x86: fix rip-relative handling of EVEX-encoded insns.

2016-08-11 Thread Oleg Nesterov
Well, I guess I have to reply... So let me say that I am not going to even try to review this change. I know absolutely nothing about x86 insn decoding, but I tend to trust Denys in this area. On 08/11, Denys Vlasenko wrote: > > Since instruction decoder now supports EVEX-encoded insns, two fixe