Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2019-03-22 Thread Paul Kocialkowski
Hi, Le vendredi 22 mars 2019 à 07:46 -0500, Bin Liu a écrit : > On Thu, Mar 21, 2019 at 05:41:38PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 21, 2019 at 02:01:33PM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > I'm reviving this thread a bit, because I encountered this bug today. > > >

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-05-01 Thread Bin Liu
On Tue, May 01, 2018 at 03:26:57PM +0200, Paul Kocialkowski wrote: > Hi, > > Le mardi 01 mai 2018 à 07:25 -0500, Bin Liu a écrit : > > On Mon, Apr 30, 2018 at 11:08:42PM +0200, Paul Kocialkowski wrote: > > > Hi, > > > > > > Le samedi 21 avril 2018 à 09:34 -0500, Bin Liu a écrit : > > > > Okay, th

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-05-01 Thread Paul Kocialkowski
Hi, Le mardi 01 mai 2018 à 07:25 -0500, Bin Liu a écrit : > On Mon, Apr 30, 2018 at 11:08:42PM +0200, Paul Kocialkowski wrote: > > Hi, > > > > Le samedi 21 avril 2018 à 09:34 -0500, Bin Liu a écrit : > > > Okay, this came down to an argument that whether we should require > > > loading a gadget d

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-05-01 Thread Bin Liu
On Mon, Apr 30, 2018 at 11:08:42PM +0200, Paul Kocialkowski wrote: > Hi, > > Le samedi 21 avril 2018 à 09:34 -0500, Bin Liu a écrit : > > Okay, this came down to an argument that whether we should require > > loading a gadget driver on a dual-role port to work in host mode, > > which is currently

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-30 Thread Paul Kocialkowski
Hi, Le samedi 21 avril 2018 à 09:34 -0500, Bin Liu a écrit : > Okay, this came down to an argument that whether we should require > loading a gadget driver on a dual-role port to work in host mode, > which is currently required on musb since a long long time ago. > > I understand the requirement

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-21 Thread Bin Liu
On Sat, Apr 21, 2018 at 12:59:23PM +0200, Paul Kocialkowski wrote: > Hi, > > Le vendredi 20 avril 2018 à 09:25 -0500, Bin Liu a écrit : > > On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > > > Hi, > > > > > > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > > > On W

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-21 Thread Paul Kocialkowski
Hi, Le vendredi 20 avril 2018 à 09:25 -0500, Bin Liu a écrit : > On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > > Hi, > > > > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > > > This allows

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-21 Thread Paul Kocialkowski
Hi, Le mardi 03 avril 2018 à 11:29 +0200, Maxime Ripard a écrit : > Hi, > > On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > > > This allows d

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-20 Thread Bin Liu
On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > Hi, > > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > > This allows dual-role ports to be reported as having gadget mode by > > > the > > > musb

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-03 Thread Maxime Ripard
Hi, On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > > This allows dual-role ports to be reported as having gadget mode by > > > the > > > musb_has

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-03-29 Thread Paul Kocialkowski
Hi, On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > This allows dual-role ports to be reported as having gadget mode by > > the > > musb_has_gadget helper. This is required to enable MUSB at all with > > MUSB > > glue

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-03-29 Thread Maxime Ripard
On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > This allows dual-role ports to be reported as having gadget mode by the > musb_has_gadget helper. This is required to enable MUSB at all with MUSB > glue layers that set the port mode to MUSB_PORT_MODE_DUAL_ROLE at init. > > Most