Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-23 Thread Michael S. Tsirkin
On Fri, May 17, 2013 at 09:12:39AM +0930, Rusty Russell wrote: > Joe Perches writes: > > On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > >> Asias He writes: > >> > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > > [] > >> > Other users are using memcpy_fromiovec and fri

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-20 Thread Dmitry Torokhov
On Monday, May 20, 2013 10:07:14 AM Asias He wrote: > On Fri, May 17, 2013 at 04:25:49PM +0930, Rusty Russell wrote: > > Randy Dunlap writes: > > > On 05/16/13 16:42, Rusty Russell wrote: > > >> Joe Perches writes: > > >>> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > > Asias He

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-19 Thread Asias He
On Fri, May 17, 2013 at 04:25:49PM +0930, Rusty Russell wrote: > Randy Dunlap writes: > > On 05/16/13 16:42, Rusty Russell wrote: > >> Joe Perches writes: > >>> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-19 Thread Rusty Russell
Randy Dunlap writes: > On 05/16/13 16:42, Rusty Russell wrote: >> Joe Perches writes: >>> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: Asias He writes: > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: >>> [] > Other users are using memcpy_fromiovec and fri

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-16 Thread Randy Dunlap
On 05/16/13 16:42, Rusty Russell wrote: > Joe Perches writes: >> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: >>> Asias He writes: On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: >> [] Other users are using memcpy_fromiovec and friends outside net. It seems >>>

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-16 Thread Rusty Russell
Joe Perches writes: > On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: >> Asias He writes: >> > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > [] >> > Other users are using memcpy_fromiovec and friends outside net. It seems >> > a good idea to put it in a util library. e.

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-16 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 16 May 2013 09:46:21 +0300 > On Wed, May 15, 2013 at 08:10:55PM -0700, David Miller wrote: >> From: Rusty Russell >> Date: Thu, 16 May 2013 09:05:38 +0930 >> >> > memcpy_fromiovec() has nothing to do with networking: that was just the >> > first user. Note

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Michael S. Tsirkin
On Wed, May 15, 2013 at 08:10:55PM -0700, David Miller wrote: > From: Rusty Russell > Date: Thu, 16 May 2013 09:05:38 +0930 > > > memcpy_fromiovec() has nothing to do with networking: that was just the > > first user. Note that crypto/algif_skcipher.c also uses it. The > > obvious answer is to

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Michael S. Tsirkin
On Wed, May 15, 2013 at 03:37:30PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > > Asias He writes: > > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > > > This patch fixes this build failure. > > > > > >From Randy Dunlap: > > >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 01:04:58PM +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > >> Asias He writes: > >> > scsi.c includes vhost.c which uses memcpy_fromiovec. > >> > > >> > This patch fixes this build failure. > >> > > >> >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 01:04:58PM +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > >> Asias He writes: > >> > scsi.c includes vhost.c which uses memcpy_fromiovec. > >> > > >> > This patch fixes this build failure. > >> > > >> >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Joe Perches
On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: [] > > Other users are using memcpy_fromiovec and friends outside net. It seems > > a good idea to put it in a util library. e.g. crypto/algif_skcipher.c >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Rusty Russell
Asias He writes: > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: >> Asias He writes: >> > scsi.c includes vhost.c which uses memcpy_fromiovec. >> > >> > This patch fixes this build failure. >> > >> >From Randy Dunlap: >> >''' >> >on x86_64: >> > >> >ERROR: "memcpy

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread David Miller
From: Rusty Russell Date: Thu, 16 May 2013 09:05:38 +0930 > memcpy_fromiovec() has nothing to do with networking: that was just the > first user. Note that crypto/algif_skcipher.c also uses it. The > obvious answer is to move it into lib/. +1 -- To unsubscribe from this list: send the line "un

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote: > "Nicholas A. Bellinger" writes: > > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > >> Asias He writes: > >> > scsi.c includes vhost.c which uses memcpy_fromiovec. > >> > > >> > This patch fixes this build failure. > >> >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > Asias He writes: > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > This patch fixes this build failure. > > > >From Randy Dunlap: > >''' > >on x86_64: > > > >ERROR: "memcpy_fromiovec" [drivers/vhost/vho

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 03:37:30PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > > Asias He writes: > > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > > > This patch fixes this build failure. > > > > > >From Randy Dunlap: > > >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Rusty Russell
"Nicholas A. Bellinger" writes: > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: >> Asias He writes: >> > scsi.c includes vhost.c which uses memcpy_fromiovec. >> > >> > This patch fixes this build failure. >> > >> >From Randy Dunlap: >> >''' >> >on x86_64: >> > >> >ERROR:

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Nicholas A. Bellinger
On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > Asias He writes: > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > This patch fixes this build failure. > > > >From Randy Dunlap: > >''' > >on x86_64: > > > >ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Rusty Russell
Asias He writes: > scsi.c includes vhost.c which uses memcpy_fromiovec. > > This patch fixes this build failure. > >From Randy Dunlap: >''' >on x86_64: > >ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined! > >It needs to depend on NET since net/core/ provides th

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Asias He
On Tue, May 14, 2013 at 08:10:20PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote: > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > This patch fixes this build failure. > > > >From Randy Dunlap: > >''' > >on x86_64: > > > >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Nicholas A. Bellinger
On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote: > scsi.c includes vhost.c which uses memcpy_fromiovec. > > This patch fixes this build failure. > >From Randy Dunlap: >''' >on x86_64: > >ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined! > >It needs to depe