Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-25 Thread Pankaj Gupta
+CC MST > > Philip Chen wrote: > > > Hi maintainers, > > > > > > Can anyone let me know if this patch makes sense? > > > Any comment/feedback is appreciated. > > > Thanks in advance! > > > > I'm not an expert on virtio but the code looks ok on the surface. I've > > discussed this with Dan a bit a

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-23 Thread Philip Chen
Hi maintainers, Are there any other concerns I should address for this patch? On Mon, Sep 9, 2024 at 4:52 PM Philip Chen wrote: > > Hi > > On Wed, Sep 4, 2024 at 10:54 AM Ira Weiny wrote: > > > > Philip Chen wrote: > > > Hi maintainers, > > > > > > Can anyone let me know if this patch makes sen

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-09 Thread Philip Chen
Hi On Wed, Sep 4, 2024 at 10:54 AM Ira Weiny wrote: > > Philip Chen wrote: > > Hi maintainers, > > > > Can anyone let me know if this patch makes sense? > > Any comment/feedback is appreciated. > > Thanks in advance! > > I'm not an expert on virtio but the code looks ok on the surface. I've > di

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-04 Thread Ira Weiny
Philip Chen wrote: > Hi maintainers, > > Can anyone let me know if this patch makes sense? > Any comment/feedback is appreciated. > Thanks in advance! I'm not an expert on virtio but the code looks ok on the surface. I've discussed this with Dan a bit and virtio-pmem is not heavily tested. Base

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-08-23 Thread Philip Chen
Hi maintainers, Can anyone let me know if this patch makes sense? Any comment/feedback is appreciated. Thanks in advance! On Wed, Aug 14, 2024 at 5:46 PM Philip Chen wrote: > > Add basic freeze/restore PM callbacks to support hibernation (S4): > - On freeze, delete vq and quiesce the device to p