Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-12 Thread Michal Hocko
On Wed 11-09-13 13:04:33, Hugh Dickins wrote: > On Wed, 11 Sep 2013, Michal Hocko wrote: [...] > > From 888745909da34f8aee8a208a82d467236b828d0d Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Wed, 11 Sep 2013 17:48:10 +0200 > > Subject: [PATCH] vmpressure: fix divide-by-0 in vmpressure_

Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-11 Thread Hugh Dickins
On Wed, 11 Sep 2013, Michal Hocko wrote: > On Wed 11-09-13 08:40:57, Anton Vorontsov wrote: > > On Mon, Sep 09, 2013 at 01:08:47PM +0200, Michal Hocko wrote: > > > On Fri 06-09-13 22:59:16, Hugh Dickins wrote: > > > > Hit divide-by-0 in vmpressure_work_fn(): checking vmpr->scanned before > > > > ta

Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-11 Thread Michal Hocko
On Wed 11-09-13 08:40:57, Anton Vorontsov wrote: > On Mon, Sep 09, 2013 at 01:08:47PM +0200, Michal Hocko wrote: > > On Fri 06-09-13 22:59:16, Hugh Dickins wrote: > > > Hit divide-by-0 in vmpressure_work_fn(): checking vmpr->scanned before > > > taking the lock is not enough, we must check scanned

Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-11 Thread Anton Vorontsov
On Wed, Sep 11, 2013 at 06:03:57PM +0200, Michal Hocko wrote: > The patch below. I find it little bit nicer than Hugh's original one > because having the two checks sounds more confusing. > What do you think Hugh, Anton? Acked-by: Anton Vorontsov Thanks! > --- > From 888745909da34f8aee8a208a82d

Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-11 Thread Anton Vorontsov
On Mon, Sep 09, 2013 at 01:08:47PM +0200, Michal Hocko wrote: > On Fri 06-09-13 22:59:16, Hugh Dickins wrote: > > Hit divide-by-0 in vmpressure_work_fn(): checking vmpr->scanned before > > taking the lock is not enough, we must check scanned afterwards too. > > As vmpressure_work_fn seems the be t

Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-10 Thread Anton Vorontsov
On Fri, Sep 06, 2013 at 10:59:16PM -0700, Hugh Dickins wrote: > Hit divide-by-0 in vmpressure_work_fn(): checking vmpr->scanned before > taking the lock is not enough, we must check scanned afterwards too. > > Signed-off-by: Hugh Dickins > Cc: sta...@vger.kernel.org Hm... Just trying to understa

Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-09 Thread Michal Hocko
On Fri 06-09-13 22:59:16, Hugh Dickins wrote: > Hit divide-by-0 in vmpressure_work_fn(): checking vmpr->scanned before > taking the lock is not enough, we must check scanned afterwards too. As vmpressure_work_fn seems the be the only place where we set scanned to 0 (except for the rare occasion wh

Re: [PATCH] vmpressure: fix divide-by-0 in vmpressure_work_fn

2013-09-07 Thread David Rientjes
On Fri, 6 Sep 2013, Hugh Dickins wrote: > Hit divide-by-0 in vmpressure_work_fn(): checking vmpr->scanned before > taking the lock is not enough, we must check scanned afterwards too. > > Signed-off-by: Hugh Dickins > Cc: sta...@vger.kernel.org Acked-by: David Rientjes -- To unsubscribe from t