Re: [PATCH] vxlan: Wrong type passed to %pIS

2015-02-08 Thread David Miller
From: Rasmus Villemoes Date: Sat, 7 Feb 2015 03:17:31 +0100 > src_ip is a pointer to a union vxlan_addr, one member of which is a > struct sockaddr. Passing a pointer to src_ip is wrong; one should pass > the value of src_ip itself. Since %pIS formally expects something of > type struct sockaddr

Re: [PATCH] vxlan: Wrong type passed to %pIS

2015-02-07 Thread Cong Wang
On Sat, Feb 7, 2015 at 4:34 AM, Rasmus Villemoes wrote: > On Sat, Feb 07 2015, Cong Wang wrote: > >> On Fri, Feb 6, 2015 at 6:17 PM, Rasmus Villemoes >> wrote: >>> src_ip is a pointer to a union vxlan_addr, one member of which is a >>> struct sockaddr. Passing a pointer to src_ip is wrong; one s

Re: [PATCH] vxlan: Wrong type passed to %pIS

2015-02-07 Thread Rasmus Villemoes
On Sat, Feb 07 2015, Joe Perches wrote: > On Sat, 2015-02-07 at 03:17 +0100, Rasmus Villemoes wrote: >> src_ip is a pointer to a union vxlan_addr, one member of which is a >> struct sockaddr. Passing a pointer to src_ip is wrong; one should pass >> the value of src_ip itself. Since %pIS formally

Re: [PATCH] vxlan: Wrong type passed to %pIS

2015-02-07 Thread Rasmus Villemoes
On Sat, Feb 07 2015, Cong Wang wrote: > On Fri, Feb 6, 2015 at 6:17 PM, Rasmus Villemoes > wrote: >> src_ip is a pointer to a union vxlan_addr, one member of which is a >> struct sockaddr. Passing a pointer to src_ip is wrong; one should pass >> the value of src_ip itself. Since %pIS formally ex

Re: [PATCH] vxlan: Wrong type passed to %pIS

2015-02-06 Thread Cong Wang
On Fri, Feb 6, 2015 at 6:17 PM, Rasmus Villemoes wrote: > src_ip is a pointer to a union vxlan_addr, one member of which is a > struct sockaddr. Passing a pointer to src_ip is wrong; one should pass > the value of src_ip itself. Since %pIS formally expects something of > type struct sockaddr*, let

Re: [PATCH] vxlan: Wrong type passed to %pIS

2015-02-06 Thread Joe Perches
On Sat, 2015-02-07 at 03:17 +0100, Rasmus Villemoes wrote: > src_ip is a pointer to a union vxlan_addr, one member of which is a > struct sockaddr. Passing a pointer to src_ip is wrong; one should pass > the value of src_ip itself. Since %pIS formally expects something of > type struct sockaddr*, l