Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-05-14 Thread Wim Van Sebroeck
All, > > On Fri, May 12, 2017 at 12:36:27PM +0200, Johan Hovold wrote: > > > Hi Guenter and Wim, > > > > > > On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote: > > > > On 04/03/2017 01:36 AM, Johan Hovold wrote: > > > > > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote:

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-05-14 Thread Wim Van Sebroeck
All, > On Fri, May 12, 2017 at 12:36:27PM +0200, Johan Hovold wrote: > > Hi Guenter and Wim, > > > > On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote: > > > On 04/03/2017 01:36 AM, Johan Hovold wrote: > > > > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote: > > > >> On

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-05-12 Thread Guenter Roeck
On Fri, May 12, 2017 at 12:36:27PM +0200, Johan Hovold wrote: > Hi Guenter and Wim, > > On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote: > > On 04/03/2017 01:36 AM, Johan Hovold wrote: > > > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote: > > >> On Mon, Mar 13, 2017 at

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-05-12 Thread Johan Hovold
Hi Guenter and Wim, On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote: > On 04/03/2017 01:36 AM, Johan Hovold wrote: > > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote: > >> On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote: > >>> Make sure to check the number

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-04-03 Thread Guenter Roeck
On 04/03/2017 01:36 AM, Johan Hovold wrote: On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote: On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote: Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fi

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-04-03 Thread Johan Hovold
On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote: > On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote: > > Make sure to check the number of endpoints to avoid dereferencing a > > NULL-pointer should a malicious device lack endpoints. > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-03-13 Thread Guenter Roeck
On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer should a malicious device lack endpoints. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable > Signed-off-by: Johan Hovold Reviewed-by: Guent

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-03-13 Thread Guenter Roeck
On Mon, Mar 13, 2017 at 03:17:39PM +0100, Johan Hovold wrote: > [ Adding linux-usb which I forgot to CC for this one ] > > On Mon, Mar 13, 2017 at 06:42:45AM -0700, Guenter Roeck wrote: > > On 03/13/2017 05:49 AM, Johan Hovold wrote: > > > Make sure to check the number of endpoints to avoid derefe

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-03-13 Thread Johan Hovold
[ Adding linux-usb which I forgot to CC for this one ] On Mon, Mar 13, 2017 at 06:42:45AM -0700, Guenter Roeck wrote: > On 03/13/2017 05:49 AM, Johan Hovold wrote: > > Make sure to check the number of endpoints to avoid dereferencing a > > NULL-pointer should a malicious device lack endpoints. > >

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

2017-03-13 Thread Guenter Roeck
On 03/13/2017 05:49 AM, Johan Hovold wrote: Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Is this theory or was it actually observed ? Thanks, Guenter Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off