Re: [PATCH] writeback: fix NULL dereference when device is gone

2013-09-04 Thread Tejun Heo
Hello, On Thu, Aug 29, 2013 at 12:31:11AM +0200, Peter Wu wrote: > I applied your fix in the workfn, but now dd does not stop with EIO. If I run > `sync`, then I see: > > [11882.645618] quiet_error: 591905 callbacks suppressed > [11882.650589] Buffer I/O error on device sdd, logical block 129652

Re: [PATCH] writeback: fix NULL dereference when device is gone

2013-08-28 Thread Peter Wu
Hi, On Tuesday 20 August 2013 09:33:08 Tejun Heo wrote: > On Tue, Aug 20, 2013 at 12:13:58PM +0200, Peter Wu wrote: > ... > > > > Hmmm... bdi->dev is cleared after bdi_wb_shutdown() so the work item > > > should no longer be running. It seems like something is queueing the > > > work item after

Re: [PATCH] writeback: fix NULL dereference when device is gone

2013-08-20 Thread Tejun Heo
Hello, On Tue, Aug 20, 2013 at 12:13:58PM +0200, Peter Wu wrote: ... > > Hmmm... bdi->dev is cleared after bdi_wb_shutdown() so the work item > > should no longer be running. It seems like something is queueing the > > work item after shutdown and the proper fix would be finding out which > > and

Re: [PATCH] writeback: fix NULL dereference when device is gone

2013-08-20 Thread Peter Wu
On Monday 19 August 2013 19:02:40 Tejun Heo wrote: > On Tue, Aug 20, 2013 at 12:45:53AM +0200, Peter Wu wrote: > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > > index 68851ff..6e38a8b 100644 > > --- a/fs/fs-writeback.c > > +++ b/fs/fs-writeback.c > > @@ -1007,7 +1007,8 @@ void bdi_writebac

Re: [PATCH] writeback: fix NULL dereference when device is gone

2013-08-19 Thread Tejun Heo
On Tue, Aug 20, 2013 at 12:45:53AM +0200, Peter Wu wrote: > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 68851ff..6e38a8b 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -1007,7 +1007,8 @@ void bdi_writeback_workfn(struct work_struct *work) > struct backing_dev_i