Re: [PATCH] x86, kaslr: propagate base load address calculation

2015-02-10 Thread Jiri Kosina
On Wed, 11 Feb 2015, Jiri Kosina wrote: > Alternatively, we can forbid zero-sized randomization, and always enforce > at least some minimal offset to be chosen in case zero would be chosen. Okay, I see, that might not be always possible, depending on the memory map layout. So I'll just send yo

Re: [PATCH] x86, kaslr: propagate base load address calculation

2015-02-10 Thread Jiri Kosina
On Tue, 10 Feb 2015, Kees Cook wrote: > > Instead of fixing the logic in module.c, this patch takes more generic > > aproach, and exposes __KERNEL_OFFSET macro, which calculates the real > > offset that has been established by choose_kernel_location() during boot. > > This can be used later by oth

Re: [PATCH] x86, kaslr: propagate base load address calculation

2015-02-10 Thread Kees Cook
On Tue, Feb 10, 2015 at 5:17 AM, Jiri Kosina wrote: > Commit e2b32e678 ("x86, kaslr: randomize module base load address") makes > the base address for module to be unconditionally randomized in case when > CONFIG_RANDOMIZE_BASE is defined and "nokaslr" option isn't present on the > commandline. >