Re: [PATCH] x86, syscalls: use SYSCALL_DEFINE() macros for sys_modify_ldt()

2017-10-18 Thread Ingo Molnar
* Dave Hansen wrote: > > We do not have tracepoints for sys_modify_ldt() because we define > it directly instead of using the normal SYSCALL_DEFINEx() macros. > > However, there is a reason sys_modify_ldt() does not use the macros: > it has an 'int' return type instead of 'unsigned long'. Thi

Re: [PATCH] x86, syscalls: use SYSCALL_DEFINE() macros for sys_modify_ldt()

2017-10-18 Thread Brian Gerst
On Tue, Oct 17, 2017 at 12:22 PM, Dave Hansen wrote: > > We do not have tracepoints for sys_modify_ldt() because we define > it directly instead of using the normal SYSCALL_DEFINEx() macros. > > However, there is a reason sys_modify_ldt() does not use the macros: > it has an 'int' return type inst

Re: [PATCH] x86, syscalls: use SYSCALL_DEFINE() macros for sys_modify_ldt()

2017-10-18 Thread Dave Hansen
On 10/18/2017 06:17 AM, Ingo Molnar wrote: > I have added your: > > Signed-off-by: Dave Hansen > > let me know if that's OK. Yes, that's OK.

Re: [PATCH] x86, syscalls: use SYSCALL_DEFINE() macros for sys_modify_ldt()

2017-10-18 Thread Ingo Molnar
* Dave Hansen wrote: > > We do not have tracepoints for sys_modify_ldt() because we define > it directly instead of using the normal SYSCALL_DEFINEx() macros. > > However, there is a reason sys_modify_ldt() does not use the macros: > it has an 'int' return type instead of 'unsigned long'. Thi

Re: [PATCH] x86, syscalls: use SYSCALL_DEFINE() macros for sys_modify_ldt()

2017-10-17 Thread Andy Lutomirski
On Tue, Oct 17, 2017 at 12:22 PM, Dave Hansen wrote: > > We do not have tracepoints for sys_modify_ldt() because we define > it directly instead of using the normal SYSCALL_DEFINEx() macros. > > However, there is a reason sys_modify_ldt() does not use the macros: > it has an 'int' return type inst