Re: [PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-16 Thread Martin Kelly
On 09/15/2014 11:38 PM, Ingo Molnar wrote: > > This uglifies the code which is bad. A nicer fix would be to > improve the code: for example define pmc_dbgfs_register() in the > !DEBUG_FS case as well, with a return 0 or so. > > Thanks, > > Ingo > I like your suggestion and will issue a

Re: [PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-15 Thread Ingo Molnar
* Martin Kelly wrote: > When compiling with CONFIG_DEBUG_FS=n, gcc emits an unused variable > warning for pmc_atom.c because "ret" is used only within the > CONFIG_DEBUG_FS block. This patch fixes it up to eliminate "ret" when > CONFIG_DEBUG_FS=n. > > Signed-off-by: Martin Kelly > --- > arch/