Re: [PATCH] x86: Fix multiple coding style issues

2014-12-26 Thread Jeremiah Mahler
Alexander, On Fri, Dec 26, 2014 at 11:09:53PM +0600, Alexander Kuleshov wrote: > Hello Jeremiah, > > Thank you for feedback. It is my first patches to kernel, so i have a > some little questions: > I recommend checking out Greg Kroah Hartman's presentation on submitting your first patch. It has

Re: [PATCH] x86: Fix multiple coding style issues

2014-12-26 Thread Alexander Kuleshov
> Jeremiah Mahler : If you are looking for things to fix I suggest looking in the drivers/staging directory. There are lots of things that need to be fixed in there. Ah sorry, read it incorrectly. 2014-12-26 23:09 GMT+06:00 Alexander Kuleshov : > Hello Jeremiah, > > Thank you for feedback. It is

Re: [PATCH] x86: Fix multiple coding style issues

2014-12-26 Thread Alexander Kuleshov
Hello Jeremiah, Thank you for feedback. It is my first patches to kernel, so i have a some little questions: > Jeremiah Mahler : > Alexander, > > On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote: > > Your description needs to be more specific than just "coding style > fixes". W

Re: [PATCH] x86: Fix multiple coding style issues

2014-12-26 Thread Jeremiah Mahler
Alexander, On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote: Your description needs to be more specific than just "coding style fixes". What type of problems did you fix? How did you find them? (more inline...) > Signed-off-by: Alexander Kuleshov > --- > arch/x86/boot/head