Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

* Wanpeng Li wrote: > Hi Ingo, Thomas, > 2016-06-22 9:28 GMT+08:00 Wanpeng Li : > > From: Wanpeng Li > > > > [ cut here ] > > WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 > > ex_handler_rdmsr_unsafe+0x6a/0x70 > > unchecked MSR access error: RDMSR from 0xce > > Mod

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

Hi Ingo, Thomas, 2016-06-22 9:28 GMT+08:00 Wanpeng Li : > From: Wanpeng Li > > [ cut here ] > WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 > ex_handler_rdmsr_unsafe+0x6a/0x70 > unchecked MSR access error: RDMSR from 0xce > Modules linked in: > CPU: 0 PID: 0 Comm: swa

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

Hi Jacob, 2016-06-23 15:28 GMT+08:00 Wanpeng Li : > 2016-06-23 15:09 GMT+08:00 Thomas Gleixner : >> On Wed, 22 Jun 2016, Wanpeng Li wrote: >>> After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core >> >> Where did you find that commit? It's neither in Linus tree nor in tip. > > It i

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

2016-06-23 15:09 GMT+08:00 Thomas Gleixner : > On Wed, 22 Jun 2016, Wanpeng Li wrote: >> After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core > > Where did you find that commit? It's neither in Linus tree nor in tip. It is reported by lkp. https://lkml.org/lkml/2016/6/20/110 The

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

On Wed, 22 Jun 2016, Wanpeng Li wrote: > After commit (fc141535ad8 : "x86 tsc_msr: Extend to include Intel Core Where did you find that commit? It's neither in Linus tree nor in tip. Thanks, tglx

Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest

On 22/06/2016 03:28, Wanpeng Li wrote: > > get_ratio: > - rdmsr(MSR_PLATFORM_INFO, lo, hi); > - ratio = (lo >> 8) & 0xff; > + if (!rdmsr_safe(MSR_PLATFORM_INFO, &lo, &hi)) > + ratio = (lo >> 8) & 0xff; This looks good, thanks. Paolo