Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-22 Thread Thomas Renninger
On Tuesday, January 15, 2013 05:45:43 AM Yinghai Lu wrote: > On Mon, Jan 14, 2013 at 4:54 PM, Thomas Renninger wrote: ... > > From what I can see the patch looks fine, but above part should > > simply be left out. > > then, I would like to rename it to resetusablemap instead. > > like attached.

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-14 Thread Yinghai Lu
On Mon, Jan 14, 2013 at 4:54 PM, Thomas Renninger wrote: > On Monday, January 14, 2013 11:04:36 AM Yinghai Lu wrote: >> On Mon, Jan 14, 2013 at 7:05 AM, Thomas Renninger wrote: >> > What is this for?: >> > @@ -871,6 +879,11 @@ static int __init parse_memmap_one(char >> > >> > userdef = 1;

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-14 Thread Thomas Renninger
On Monday, January 14, 2013 11:04:36 AM Yinghai Lu wrote: > On Mon, Jan 14, 2013 at 7:05 AM, Thomas Renninger wrote: > > What is this for?: > > @@ -871,6 +879,11 @@ static int __init parse_memmap_one(char > > > > userdef = 1; > > if (*p == '@') { > > > > s

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-14 Thread Yinghai Lu
On Mon, Jan 14, 2013 at 7:05 AM, Thomas Renninger wrote: > What is this for?: > @@ -871,6 +879,11 @@ static int __init parse_memmap_one(char > userdef = 1; > if (*p == '@') { > start_at = memparse(p+1, &p); > + if (exactusablemap_parsed) { > +

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-14 Thread Thomas Renninger
On Monday, January 14, 2013 03:43:46 AM Yinghai Lu wrote: > On Sun, Jan 13, 2013 at 6:08 PM, Thomas Renninger wrote: > > On Saturday, January 12, 2013 09:07:12 AM Yinghai Lu wrote: ... > everyone could understand it straightforward: > exactmap: memmap will be specified, and it should be honored w

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-13 Thread Yinghai Lu
On Sun, Jan 13, 2013 at 6:08 PM, Thomas Renninger wrote: > On Saturday, January 12, 2013 09:07:12 AM Yinghai Lu wrote: >> On Sat, Jan 12, 2013 at 3:31 AM, Thomas Renninger wrote: >> > memmap=exactmap [KNL,X86] Enable setting of an exact >> > >> > - E820 memory map, a

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-13 Thread Thomas Renninger
On Saturday, January 12, 2013 09:07:12 AM Yinghai Lu wrote: > On Sat, Jan 12, 2013 at 3:31 AM, Thomas Renninger wrote: > > memmap=exactmap [KNL,X86] Enable setting of an exact > > > > - E820 memory map, as specified by the user. > > - Such memma

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-12 Thread Yinghai Lu
On Sat, Jan 12, 2013 at 3:31 AM, Thomas Renninger wrote: > memmap=exactmap [KNL,X86] Enable setting of an exact > - E820 memory map, as specified by the user. > - Such memmap=exactmap lines can be constructed based on > - BI

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-12 Thread Thomas Renninger
On Friday, January 11, 2013 02:16:35 PM H. Peter Anvin wrote: > On 01/11/2013 01:09 PM, Yinghai Lu wrote: > > On Fri, Jan 11, 2013 at 12:06 PM, H. Peter Anvin wrote: > >> On 01/11/2013 11:59 AM, Yinghai Lu wrote: > >>> On Fri, Jan 11, 2013 at 10:24 AM, Thomas Renninger wrote: > > We may need

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-11 Thread H. Peter Anvin
On 01/11/2013 01:09 PM, Yinghai Lu wrote: > On Fri, Jan 11, 2013 at 12:06 PM, H. Peter Anvin wrote: >> On 01/11/2013 11:59 AM, Yinghai Lu wrote: >>> On Fri, Jan 11, 2013 at 10:24 AM, Thomas Renninger wrote: > We may need to keep exactmap intact. Why? Kexec/kdump should have been the

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-11 Thread Yinghai Lu
On Fri, Jan 11, 2013 at 12:06 PM, H. Peter Anvin wrote: > On 01/11/2013 11:59 AM, Yinghai Lu wrote: >> On Fri, Jan 11, 2013 at 10:24 AM, Thomas Renninger wrote: We may need to keep exactmap intact. >>> Why? >>> Kexec/kdump should have been the only user? >>> If older/current kexec calls stil

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-11 Thread H. Peter Anvin
On 01/11/2013 11:59 AM, Yinghai Lu wrote: > On Fri, Jan 11, 2013 at 10:24 AM, Thomas Renninger wrote: >>> We may need to keep exactmap intact. >> Why? >> Kexec/kdump should have been the only user? >> If older/current kexec calls still add ACPI maps via memmap=X#Y, >> they should already exist in

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-11 Thread Yinghai Lu
On Fri, Jan 11, 2013 at 10:24 AM, Thomas Renninger wrote: >> We may need to keep exactmap intact. > Why? > Kexec/kdump should have been the only user? > If older/current kexec calls still add ACPI maps via memmap=X#Y, > they should already exist in the original e820 map and fall off or > get glued

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-11 Thread Thomas Renninger
On Friday, January 11, 2013 08:16:52 AM Yinghai Lu wrote: > On Fri, Jan 11, 2013 at 4:33 AM, Thomas Renninger wrote: ... > > - e820.nr_map = 0; > > + /* > > +* Remove all usable memory (this is for kdump), usable > > +* memory will be pas

Re: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case

2013-01-11 Thread Yinghai Lu
On Fri, Jan 11, 2013 at 4:33 AM, Thomas Renninger wrote: >> yes, we have other user for debug like simulating user memmap for some >> bugs. >> current problem for exactmap is that we don't scan that at first. >> attached patch could help that. > > Yep, this is what I would have come up as well or