Re: [PATCH] zram: Replace pr_* with dev_*

2015-08-04 Thread Joe Perches
On Wed, 2015-08-05 at 08:57 +0900, Sergey Senozhatsky wrote: > On (08/05/15 08:42), Sergey Senozhatsky wrote: > > what's the benefit? > > and apart from that I don't understand why do you replace some > pr_info() with dev_warn(). f.e. And besides that, the formats should not be changed and still

Re: [PATCH] zram: Replace pr_* with dev_*

2015-08-04 Thread Sergey Senozhatsky
On (08/05/15 08:42), Sergey Senozhatsky wrote: > what's the benefit? and apart from that I don't understand why do you replace some pr_info() with dev_warn(). f.e. [..] > > if (!zcomp_set_max_streams(zram->comp, num)) { > > - pr_info("Cannot change max compression st

Re: [PATCH] zram: Replace pr_* with dev_*

2015-08-04 Thread Sergey Senozhatsky
On (08/04/15 20:22), Salah Triki wrote: > This patch replaces pr_info/pr_warn/pr_err with > dev_info/dev_warn/dev_err. Hi, what's the benefit? -ss > Signed-off-by: Salah Triki > --- > drivers/block/zram/zram_drv.c | 40 +++- > 1 file changed, 23 ins