Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-27 Thread Minchan Kim
Hi Nick, On Fri, Aug 25, 2017 at 07:31:14PM +, Nick Terrell wrote: > On 8/24/17, 10:19 PM, "Minchan Kim" wrote: > > On Fri, Aug 25, 2017 at 01:35:35AM +, Nick Terrell wrote: > [..] > > > I think using dictionaries in zram could be very interesting. We could for > > > example, take a rando

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-25 Thread Nick Terrell
On 8/24/17, 10:19 PM, "Minchan Kim" wrote: > On Fri, Aug 25, 2017 at 01:35:35AM +, Nick Terrell wrote: [..] > > I think using dictionaries in zram could be very interesting. We could for > > example, take a random sample of the RAM and use that as the dictionary > > for compression. E.g. take

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-25 Thread Nick Terrell
On 8/24/17, 9:51 PM, "Minchan Kim" wrote: >Off-topic: > >In all ways, zstd beats deflate. Nick, Right? Yeah. Since all LZ compression algorithms are heuristics, there are some rare cases where zlib beats zstd in compression ratio by a bit, but never speed. In all cases where we've deployed zstd,

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-25 Thread Adam Borowski
On Fri, Aug 25, 2017 at 04:45:33PM +0900, Sergey Senozhatsky wrote: > that may lead to a bigger/more general question: > > - if zstd is so much better, then do we need deflate/inflate at all in > the kernel? may be zstd can replace it? zram and vmlinuz/modules are about the only cases that can

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-25 Thread Sergey Senozhatsky
On (08/25/17 14:36), Minchan Kim wrote: [..] > > hmmm... frankly, I don't think it would confuse anyone. the code is > > there - compiled - anyway, and the module is visible in /proc/crypto > > etc. if we will make it unavailable in zram then this can be confusing, > > probably... if anyone ever pa

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Minchan Kim
On Fri, Aug 25, 2017 at 02:06:44PM +0900, Sergey Senozhatsky wrote: < snip > > > Off-topic: > > > > In all ways, zstd beats deflate. Nick, Right? > > > > With zstd, I doubt we should show "deflate" to user. Many options just > > make user confused. > > The inflate have been there for representi

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Sergey Senozhatsky
On (08/25/17 14:06), Sergey Senozhatsky wrote: > > Off-topic: > > > > In all ways, zstd beats deflate. Nick, Right? > > > > With zstd, I doubt we should show "deflate" to user. Many options just > > make user confused. > > The inflate have been there for representing high comp ratio but slower >

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Sergey Senozhatsky
On (08/25/17 02:46), Nick Terrell wrote: > On 8/24/17, 7:21 PM, "Sergey Senozhatsky" > wrote: > > not really familiar either... I was thinking about having "zstd" and > > "zstd_dict" crypto_alg structs - one would be !dict, the other one would > > allocate dict and pass it to compress/decompress

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Minchan Kim
Hi Nick, On Fri, Aug 25, 2017 at 01:35:35AM +, Nick Terrell wrote: > On 8/24/17, 5:49 PM, "Joonsoo Kim" wrote: > > On Thu, Aug 24, 2017 at 09:33:54PM +, Nick Terrell wrote: > > > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > > > Add ZSTD to the list of supported

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Sergey Senozhatsky
On (08/25/17 13:50), Minchan Kim wrote: [..] > Thanks for the testing. > Could you resend the patch with this test result with my acked-by? ok. > Acked-by: Minchan Kim thanks. > Off-topic: > > In all ways, zstd beats deflate. Nick, Right? > > With zstd, I doubt we should show "deflate" to us

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Minchan Kim
Hi Sergey, On Thu, Aug 24, 2017 at 11:04:40PM +0900, Sergey Senozhatsky wrote: > Hi, > > On (08/24/17 13:30), Minchan Kim wrote: > > Hello Sergey, > > > > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > > Add ZSTD to the list of supported compression algorithms. > > > >

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Nick Terrell
On 8/24/17, 7:21 PM, "Sergey Senozhatsky" wrote: > not really familiar either... I was thinking about having "zstd" and > "zstd_dict" crypto_alg structs - one would be !dict, the other one would > allocate dict and pass it to compress/decompress zstd callbacks. "zstd" > vecrsion would invoke zstd

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Sergey Senozhatsky
On (08/25/17 02:09), Nick Terrell wrote: [..] > > > I think using dictionaries in zram could be very interesting. We could for > > > example, take a random sample of the RAM and use that as the dictionary > > > for compression. E.g. take 32 512B samples from RAM and build a 16 KB > > > dictionary (

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Nick Terrell
On 8/24/17, 6:53 PM, "Sergey Senozhatsky" wrote: > On (08/25/17 01:35), Nick Terrell wrote: > > On 8/24/17, 5:49 PM, "Joonsoo Kim" wrote: > > > On Thu, Aug 24, 2017 at 09:33:54PM +, Nick Terrell wrote: > > > > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > > > > Add

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Joonsoo Kim
On Fri, Aug 25, 2017 at 01:35:35AM +, Nick Terrell wrote: > On 8/24/17, 5:49 PM, "Joonsoo Kim" wrote: > > On Thu, Aug 24, 2017 at 09:33:54PM +, Nick Terrell wrote: > > > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > > > Add ZSTD to the list of supported compressio

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Sergey Senozhatsky
On (08/25/17 01:35), Nick Terrell wrote: > On 8/24/17, 5:49 PM, "Joonsoo Kim" wrote: > > On Thu, Aug 24, 2017 at 09:33:54PM +, Nick Terrell wrote: > > > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > > > Add ZSTD to the list of supported compression algorithms. > > > >

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Nick Terrell
On 8/24/17, 5:49 PM, "Joonsoo Kim" wrote: > On Thu, Aug 24, 2017 at 09:33:54PM +, Nick Terrell wrote: > > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > > Add ZSTD to the list of supported compression algorithms. > > > > > > Official benchmarks [1]: > > > > Awesome!

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Sergey Senozhatsky
On (08/24/17 21:33), Nick Terrell wrote: > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > Add ZSTD to the list of supported compression algorithms. > > > > Official benchmarks [1]: > > Awesome! Let me know if you need anything from me. thanks! -ss

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Joonsoo Kim
On Thu, Aug 24, 2017 at 09:33:54PM +, Nick Terrell wrote: > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > Add ZSTD to the list of supported compression algorithms. > > > > Official benchmarks [1]: > > Awesome! Let me know if you need anything from me. > Hello, Nick.

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-24 Thread Sergey Senozhatsky
Hi, On (08/24/17 13:30), Minchan Kim wrote: > Hello Sergey, > > On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > > Add ZSTD to the list of supported compression algorithms. > > > > Official benchmarks [1]: > > First of all, thanks for the work! > > I want to ask one thing.

Re: [PATCH] zram: add zstd to the supported algorithms list

2017-08-23 Thread Minchan Kim
Hello Sergey, On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > Add ZSTD to the list of supported compression algorithms. > > Official benchmarks [1]: First of all, thanks for the work! I want to ask one thing. Could you add some benchmark(e.g.,) result(comp ratio and speed