Re: [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

2015-07-14 Thread Wolfram Sang
> So this additional error message would print one of, -EINVAL, -EBUSY > or -ENOMEM. The driver core can report this; dunno from head if it is verbose output or not. signature.asc Description: Digital signature

Re: [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

2015-07-14 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 05:05 PM, Wolfram Sang wrote: + i2c->reg_base = devm_ioremap_resource(&dev->dev, res); + if (IS_ERR(i2c->reg_base)) { + dev_err(&dev->dev, "failed to map resource: %ld\n", + PTR_ERR(i2c->reg_base)); + return P

Re: [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

2015-07-14 Thread Wolfram Sang
> + i2c->reg_base = devm_ioremap_resource(&dev->dev, res); > + if (IS_ERR(i2c->reg_base)) { > + dev_err(&dev->dev, "failed to map resource: %ld\n", > + PTR_ERR(i2c->reg_base)); > + return PTR_ERR(i2c->reg_base); > + } One change I did when ap