On Sun, Dec 30, 2007 at 01:38:24PM +, Adrian McMenamin wrote:
> On Thu, 2007-12-27 at 14:58 -0800, Joe Perches wrote:
> > On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote:
> > > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
> >
> > Because it was already so close
On Thu, 2007-12-27 at 14:58 -0800, Joe Perches wrote:
> On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote:
> > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> Because it was already so close, might as well make it checkpatch clean.
>
> I also added a function gdro
On Sat, 2007-12-29 at 12:03 +, Adrian McMenamin wrote:
> This won't work see include/scsi/scsi.h
> /*
> * SENSE KEYS
> */
>
> #define NO_SENSE0x00
> #define RECOVERED_ERROR 0x01
> #define NOT_READY 0x02
> #define MEDIUM_ERROR0x03
> #define HARDWARE_ERROR
On Sat, 2007-12-29 at 12:03 +, Adrian McMenamin wrote:
> On Fri, 2007-12-28 at 17:57 -0800, Joe Perches wrote:
>
> >
> > Perhaps (uncompiled/untested):
> >
> > Remove unnecessary parenthesis
> > Remove GDROM: prefix from sense_texts
> > Add function gdrom_data_request
> > Ch
On Fri, 2007-12-28 at 17:57 -0800, Joe Perches wrote:
>
> Perhaps (uncompiled/untested):
>
> Remove unnecessary parenthesis
> Remove GDROM: prefix from sense_texts
> Add function gdrom_data_request
> Check sense_key against sense_text array size
>
> Signed-off-by: Joe Perches <
On Fri, 2007-12-28 at 01:18 +0100, Simon Holm Thøgersen wrote:
> > - while ((ctrl_inb(GDROM_ALTSTATUS_REG) & 0x80) && (time_before(jiffies,
> > timeout)))
> > + while (gdrom_is_busy() && (time_before(jiffies, timeout)))
> You don't need those parentheses.
> > + while (((ctrl_inb(GDRO
On Fri, 2007-12-28 at 20:17 +0100, Gino Badouri wrote:
> Applied this over the last patch and I can confirm it works like a
> charm :)
It's Adrian's patch that works well. Thanks Adrian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL
Op donderdag 27-12-2007 om 14:58 uur [tijdzone -0800], schreef Joe
Perches:
> On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote:
> > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> Because it was already so close, might as well make it checkpatch clean.
>
> I also
On Thu, Dec 27, 2007 at 07:49:01PM -0500, Mike Frysinger wrote:
> On Thursday 27 December 2007, Joe Perches wrote:
> > I also added a function gdrom_is_busy() to make a couple of tests
> > fit on a single line and perhaps easier to read.
>
> i'd tend to agree it does make it easier to read, howeve
On Thursday 27 December 2007, Joe Perches wrote:
> On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote:
> > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> Because it was already so close, might as well make it checkpatch clean.
for the 80 col limit, that's up to the
tor, 27 12 2007 kl. 14:58 -0800, skrev Joe Perches:
> On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote:
> > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> Because it was already so close, might as well make it checkpatch clean.
>
> I also added a function gdrom_i
On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote:
> This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
Because it was already so close, might as well make it checkpatch clean.
I also added a function gdrom_is_busy() to make a couple of tests
fit on a single line and perh
On Thu, Dec 27, 2007 at 04:52:19PM +, Adrian McMenamin wrote:
> This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> The SEGA Dreamcast has a built in CD-Rom drive, electrically similar
> to an ATA-3 drive, but implementing a proprietary packet interface -
> the so-called Se
On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote:
> This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> The SEGA Dreamcast has a built in CD-Rom drive, electrically similar
> to an ATA-3 drive, but implementing a proprietary packet interface -
> the so-called Sega Pac
On Thu, Dec 27 2007, Adrian McMenamin wrote:
>
> On Thu, 2007-12-27 at 17:18 +0900, Paul Mundt wrote:
> > On Thu, Dec 27, 2007 at 01:26:47AM +, Adrian McMenamin wrote:
>
> >
> > > + /* now seek to take the request spinlock
> > > + * before handling ending the request
On Thursday 27 December 2007, Paul Mundt wrote:
> On Thu, Dec 27, 2007 at 01:26:47AM +, Adrian McMenamin wrote:
> > +static int gdrom_get_last_session(struct cdrom_device_info *cd_info,
> > struct cdrom_multisession *ms_info) +{
> > + int fentry, lentry, track, data, tocuse, err;
> > + kfre
On Thu, 2007-12-27 at 17:18 +0900, Paul Mundt wrote:
> On Thu, Dec 27, 2007 at 01:26:47AM +, Adrian McMenamin wrote:
>
> > + /* now seek to take the request spinlock
> > +* before handling ending the request */
> > + spin_lock(&gdrom_lock);
> > + lis
On Thu, Dec 27, 2007 at 01:26:47AM +, Adrian McMenamin wrote:
> This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
Please fix your mailer to inline the patch, preferably without word
wrapping. This is not a difficult thing, send yourself some test mails
until you get it sort
On Thursday 20 December 2007, Adrian McMenamin wrote:
> On 20/12/2007, Adrian McMenamin <[EMAIL PROTECTED]> wrote:
> > This patch adds support for the CD Rom device (called a "GD Rom") on
> > the SEGA Dreamcast.This device has a command block similar to a
> > standard ATA-3 device, though implement
On Fri, 2007-12-21 at 20:35 +0100, Jens Axboe wrote:
> backing_dev_info
Sorry, I know what you mean now ... left over from an earlier
experiments with read ahead. Will delete it now: didn't realise it was
still lurking there)
--
To unsubscribe from this list: send the line "unsubscribe linux-ke
On Fri, Dec 21 2007, Adrian McMenamin wrote:
>
> On Fri, 2007-12-21 at 13:14 +0100, Jens Axboe wrote:
>
> >
> > What is pages doing in gdrom_request()?
> >
>
> As the device doesn't do scatter-gather I've set
> blk_queue_max_segment_size to 1 and am not bothering with pages - is
> that wrong?
On Fri, 2007-12-21 at 13:14 +0100, Jens Axboe wrote:
>
> What is pages doing in gdrom_request()?
>
As the device doesn't do scatter-gather I've set
blk_queue_max_segment_size to 1 and am not bothering with pages - is
that wrong?
--
To unsubscribe from this list: send the line "unsubscribe lin
On Fri, Dec 21 2007, Adrian McMenamin wrote:
> On Fri, December 21, 2007 2:22 pm, Jens Axboe wrote:
> > On Fri, Dec 21 2007, Adrian McMenamin wrote:
> >> On 21/12/2007, Jens Axboe <[EMAIL PROTECTED]> wrote:
> >> >
> >> > Your design is also heavily geared towards there just being a single
> >> > CD
On Fri, December 21, 2007 2:22 pm, Jens Axboe wrote:
> On Fri, Dec 21 2007, Adrian McMenamin wrote:
>> On 21/12/2007, Jens Axboe <[EMAIL PROTECTED]> wrote:
>> >
>> > Your design is also heavily geared towards there just being a single
>> > CDROM, I'm assuming this wont be a problem given your hw (i
On Fri, Dec 21 2007, Adrian McMenamin wrote:
> On 21/12/2007, Jens Axboe <[EMAIL PROTECTED]> wrote:
> >
> > Your design is also heavily geared towards there just being a single
> > CDROM, I'm assuming this wont be a problem given your hw (it sets a bad
> > example for others to follow though, lots
On 21/12/2007, Jens Axboe <[EMAIL PROTECTED]> wrote:
>
> Your design is also heavily geared towards there just being a single
> CDROM, I'm assuming this wont be a problem given your hw (it sets a bad
> example for others to follow though, lots of violations against normal
> programming practice for
On Fri, Dec 21 2007, Jens Axboe wrote:
> static void gdrom_readdisk_dma(struct work_struct *work)
> {
> ...
>
> read_command = kzalloc(sizeof(struct packet_command), GFP_KERNEL);
> if (!read_command)
> probably just defer the work to some time later
>
>
On Fri, Dec 21 2007, Adrian McMenamin wrote:
> On 20/12/2007, Adrian McMenamin <[EMAIL PROTECTED]> wrote:
> > This patch adds support for the CD Rom device (called a "GD Rom") on
> > the SEGA Dreamcast.This device has a command block similar to a
> > standard ATA-3 device, though implements Sega's
On 20/12/2007, Adrian McMenamin <[EMAIL PROTECTED]> wrote:
> This patch adds support for the CD Rom device (called a "GD Rom") on
> the SEGA Dreamcast.This device has a command block similar to a
> standard ATA-3 device, though implements Sega's proprietary packet
> interface - the so-called "Sega
29 matches
Mail list logo
