Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Srivatsa Vaddagiri
On Thu, Sep 27, 2007 at 04:42:41PM -0700, Andrew Morton wrote: > > @@ -219,6 +225,9 @@ static inline struct task_grp *task_grp( > > > > #ifdef CONFIG_FAIR_USER_SCHED > > tg = p->user->tg; > > +#elif CONFIG_FAIR_CGROUP_SCHED > > + tg = container_of(task_subsys_state(p, cpu_cgroup_subsys_id)

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Andrew Morton
On Fri, 28 Sep 2007 01:05:12 +0530 Dhaval Giani <[EMAIL PROTECTED]> wrote: > On Thu, Sep 27, 2007 at 12:00:33PM -0700, Randy Dunlap wrote: > > On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote: > > > > > > > > > +config RESOURCE_COUNTERS > > > + bool "Resource counters" > > > + help > > > +

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Frans Pop
Dhaval Giani wrote: > +config FAIR_CGROUP_SCHED > + bool "Control groups" > + depends on CGROUPS > + help There are also stray spaces before the tab on the last two lines above. Cheers, Frans Pop - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Dhaval Giani
On Thu, Sep 27, 2007 at 12:00:33PM -0700, Randy Dunlap wrote: > On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote: > > > > > > +config RESOURCE_COUNTERS > > + bool "Resource counters" > > + help > > + This option enables controller independent resource accounting > > Above line is ta

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Randy Dunlap
On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote: > > > +config RESOURCE_COUNTERS > > > + bool "Resource counters" > > > + help > > > + This option enables controller independent resource accounting > > > + infrastructure that works with cgroups > > > > Use tab + 2 spaces consiste

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Dhaval Giani
On Thu, Sep 27, 2007 at 10:40:05AM -0700, Randy Dunlap wrote: > On Thu, 27 Sep 2007 20:36:24 +0530 Srivatsa Vaddagiri wrote: > Hi :) > > Uh, a few of my previous comments weren't fixed... (below) > > > > -- > > > > Enable "cgroup" (formerly containers) based fair group scheduling. > > This wil

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Randy Dunlap
On Thu, 27 Sep 2007 20:36:24 +0530 Srivatsa Vaddagiri wrote: > Andrew, > This is a resend of the patch I had sent earlier at: > > http://marc.info/?l=linux-kernel&m=119065506607858 > > This patch enables group cpu scheduler feature to work with control > groups. > > Could you includ