Re: [PATCH -mm -v3] x86 boot : export boot_params via sysfs

2007-12-17 Thread Huang, Ying
On Mon, 2007-12-17 at 21:34 -0700, Eric W. Biederman wrote: > "H. Peter Anvin" <[EMAIL PROTECTED]> writes: > > > This is directly analogous to how we treat identity information in IDE, or > > PCI > > configuration space -- some fields are pre-digested, but the entire raw > > information is also a

Re: [PATCH -mm -v3] x86 boot : export boot_params via sysfs

2007-12-17 Thread Eric W. Biederman
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > This is directly analogous to how we treat identity information in IDE, or PCI > configuration space -- some fields are pre-digested, but the entire raw > information is also available. Add to that a totally unchanged value can just be easier to get

Re: [PATCH -mm -v3] x86 boot : export boot_params via sysfs

2007-12-14 Thread H. Peter Anvin
H. Peter Anvin wrote: Greg KH wrote: But it ignored the fact that I said I didn't want this binary file in sysfs :) Please take Eric's suggestion and split it up into the different pieces. Some of the fields can be binary files, as they come directly from the firmware, but the others should be

Re: [PATCH -mm -v3] x86 boot : export boot_params via sysfs

2007-12-14 Thread H. Peter Anvin
Greg KH wrote: But it ignored the fact that I said I didn't want this binary file in sysfs :) Please take Eric's suggestion and split it up into the different pieces. Some of the fields can be binary files, as they come directly from the firmware, but the others should be text. But PLEASE in

Re: [PATCH -mm -v3] x86 boot : export boot_params via sysfs

2007-12-14 Thread Greg KH
On Fri, Dec 14, 2007 at 04:16:46PM +0800, Huang, Ying wrote: > This patch export the boot parameters via sysfs. This can be used for > debugging and kexec. > > The files added are as follow: > > /sys/kernel/boot_params/data : binary file for struct boot_params > /sys/kernel/boot_params/version