Re: [PATCH -mm 7/9] netconsole: Support multiple logging targets

Hi, On Sun, 8 Jul 2007, KII Keiichi wrote: > Hi Satyam, > > The following comments aren't essential. > > > if (!(event == NETDEV_UP || event == NETDEV_DOWN || > > event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME)) > > - goto done; > > + goto done; > > T

Re: [PATCH -mm 7/9] netconsole: Support multiple logging targets

Hi Satyam, The following comments aren't essential. > if (!(event == NETDEV_UP || event == NETDEV_DOWN || > event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME)) > - goto done; > + goto done; The above diff lines are extra. > + spin_lock_irqsav