Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread miaoqinglang
在 2020/7/16 20:39, luojiaxing 写道: Hi, Qinglang On 2020/7/16 16:47, Qinglang Miao wrote: From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu ---   drivers/scsi/hisi_sas/hisi_sas_main.c | 137 ++   1 file changed, 10

Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-16 Thread miaoqinglang
在 2020/7/16 20:39, luojiaxing 写道: Hi, Qinglang On 2020/7/16 16:47, Qinglang Miao wrote: From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu ---   drivers/scsi/hisi_sas/hisi_sas_main.c | 137 ++   1 file changed, 10

Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-16 Thread miaoqinglang
在 2020/7/16 17:25, John Garry 写道: On 16/07/2020 09:47, Qinglang Miao wrote: Not sure why you cc Greg, but SCSI maintainers should have been - James and Martin From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu The sender is not the

Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-16 Thread luojiaxing
Hi, Qinglang On 2020/7/16 16:47, Qinglang Miao wrote: From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu --- drivers/scsi/hisi_sas/hisi_sas_main.c | 137 ++ 1 file changed, 10 insertions(+), 127 deletions(-) diff

Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-16 Thread John Garry
On 16/07/2020 09:47, Qinglang Miao wrote: Not sure why you cc Greg, but SCSI maintainers should have been - James and Martin From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu The sender is not the author, so your signed-off-by should