Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-19 Thread Paul E. McKenney
On Mon, Aug 19, 2019 at 11:46:36AM -0400, Joel Fernandes wrote: > On Mon, Aug 19, 2019 at 07:41:08AM -0700, Paul E. McKenney wrote: > > On Mon, Aug 19, 2019 at 10:22:08AM -0400, Joel Fernandes wrote: > > > On Mon, Aug 19, 2019 at 02:59:08PM +0200, Frederic Weisbecker wrote: > > > > On Fri, Aug 16,

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-19 Thread Joel Fernandes
On Mon, Aug 19, 2019 at 07:41:08AM -0700, Paul E. McKenney wrote: > On Mon, Aug 19, 2019 at 10:22:08AM -0400, Joel Fernandes wrote: > > On Mon, Aug 19, 2019 at 02:59:08PM +0200, Frederic Weisbecker wrote: > > > On Fri, Aug 16, 2019 at 09:52:42AM -0700, Paul E. McKenney wrote: > > > > On Fri, Aug 16

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-19 Thread Paul E. McKenney
On Mon, Aug 19, 2019 at 10:22:08AM -0400, Joel Fernandes wrote: > On Mon, Aug 19, 2019 at 02:59:08PM +0200, Frederic Weisbecker wrote: > > On Fri, Aug 16, 2019 at 09:52:42AM -0700, Paul E. McKenney wrote: > > > On Fri, Aug 16, 2019 at 12:24:04PM -0400, Joel Fernandes wrote: > > > > On Thu, Aug 15,

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-19 Thread Paul E. McKenney
On Mon, Aug 19, 2019 at 02:59:08PM +0200, Frederic Weisbecker wrote: > On Fri, Aug 16, 2019 at 09:52:42AM -0700, Paul E. McKenney wrote: > > On Fri, Aug 16, 2019 at 12:24:04PM -0400, Joel Fernandes wrote: > > > On Thu, Aug 15, 2019 at 10:53:11PM -0400, Joel Fernandes (Google) wrote: > > > > I reall

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-19 Thread Joel Fernandes
On Mon, Aug 19, 2019 at 02:59:08PM +0200, Frederic Weisbecker wrote: > On Fri, Aug 16, 2019 at 09:52:42AM -0700, Paul E. McKenney wrote: > > On Fri, Aug 16, 2019 at 12:24:04PM -0400, Joel Fernandes wrote: > > > On Thu, Aug 15, 2019 at 10:53:11PM -0400, Joel Fernandes (Google) wrote: > > > > I reall

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-19 Thread Frederic Weisbecker
On Fri, Aug 16, 2019 at 09:52:42AM -0700, Paul E. McKenney wrote: > On Fri, Aug 16, 2019 at 12:24:04PM -0400, Joel Fernandes wrote: > > On Thu, Aug 15, 2019 at 10:53:11PM -0400, Joel Fernandes (Google) wrote: > > > I really cannot explain this patch, but without it, the "else if" block > > > just d

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-16 Thread Paul E. McKenney
On Fri, Aug 16, 2019 at 01:07:00PM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 09:52:42AM -0700, Paul E. McKenney wrote: > > On Fri, Aug 16, 2019 at 12:24:04PM -0400, Joel Fernandes wrote: > > > On Thu, Aug 15, 2019 at 10:53:11PM -0400, Joel Fernandes (Google) wrote: > > > > I really can

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-16 Thread Joel Fernandes
On Fri, Aug 16, 2019 at 09:52:42AM -0700, Paul E. McKenney wrote: > On Fri, Aug 16, 2019 at 12:24:04PM -0400, Joel Fernandes wrote: > > On Thu, Aug 15, 2019 at 10:53:11PM -0400, Joel Fernandes (Google) wrote: > > > I really cannot explain this patch, but without it, the "else if" block > > > just d

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-16 Thread Paul E. McKenney
On Fri, Aug 16, 2019 at 12:24:04PM -0400, Joel Fernandes wrote: > On Thu, Aug 15, 2019 at 10:53:11PM -0400, Joel Fernandes (Google) wrote: > > I really cannot explain this patch, but without it, the "else if" block > > just doesn't execute thus causing the tick's dep mask to not be set and > > caus

Re: [PATCH -rcu dev 3/3] RFC: rcu/tree: Read dynticks_nmi_nesting in advance

2019-08-16 Thread Joel Fernandes
On Thu, Aug 15, 2019 at 10:53:11PM -0400, Joel Fernandes (Google) wrote: > I really cannot explain this patch, but without it, the "else if" block > just doesn't execute thus causing the tick's dep mask to not be set and > causes the tick to be turned off. > > I tried various _ONCE() macros but th