Re: [PATCH -rt] CONFIG_PARAVIRT and CONFIG_MCOUNT don't play well together

2007-06-22 Thread Jeremy Fitzhardinge
Chris Wright wrote: Yes, I agree, it's actually documenting the subtlety of the calling convention, not just noise in the source. The upstream patch is different, I'll sort one out. I wonder if we should use something like "regparm" rather than "fastcall"? The latter makes it sound like its

Re: [PATCH -rt] CONFIG_PARAVIRT and CONFIG_MCOUNT don't play well together

2007-06-22 Thread Ingo Molnar
* Chris Wright <[EMAIL PROTECTED]> wrote: > * Steven Rostedt ([EMAIL PROTECTED]) wrote: > > Chris, thanks a hell of a lot for looking into this!!! > > > > -rt doesn't do much with paravirt, but since both -rt and lguest are two > > things I love to play with, it was really bothering me that they

Re: [PATCH -rt] CONFIG_PARAVIRT and CONFIG_MCOUNT don't play well together

2007-06-22 Thread Ingo Molnar
* Chris Wright <[EMAIL PROTECTED]> wrote: > > thanks! I ran into this before and asked for the fastcalls to not be > > removed from upstream paravirt.c but to no avail it seems. It does > > no harm to anyone to keep the 'fastcall' declarations and > > definitions for places where _actual assem

Re: [PATCH -rt] CONFIG_PARAVIRT and CONFIG_MCOUNT don't play well together

2007-06-22 Thread Chris Wright
* Steven Rostedt ([EMAIL PROTECTED]) wrote: > Chris, thanks a hell of a lot for looking into this!!! > > -rt doesn't do much with paravirt, but since both -rt and lguest are two > things I love to play with, it was really bothering me that they were > not getting along. It was bugging me too, now

Re: [PATCH -rt] CONFIG_PARAVIRT and CONFIG_MCOUNT don't play well together

2007-06-22 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > * Chris Wright <[EMAIL PROTECTED]> wrote: > > Current -rt is broken when compiling with CONFIG_PARAVIRT and > > CONFIG_MCOUNT both enabled. Because CONFIG_MCOUNT disables > > CONFIG_REGPARM, the calling convention must once again be explicit > > with f

Re: [PATCH -rt] CONFIG_PARAVIRT and CONFIG_MCOUNT don't play well together

2007-06-22 Thread Steven Rostedt
On Fri, 2007-06-22 at 01:06 -0700, Chris Wright wrote: > Current -rt is broken when compiling with CONFIG_PARAVIRT and > CONFIG_MCOUNT both enabled. Because CONFIG_MCOUNT disables > CONFIG_REGPARM, the calling convention must once again be explicit > with fastcall. However, this was only half-way

Re: [PATCH -rt] CONFIG_PARAVIRT and CONFIG_MCOUNT don't play well together

2007-06-22 Thread Ingo Molnar
* Chris Wright <[EMAIL PROTECTED]> wrote: > Current -rt is broken when compiling with CONFIG_PARAVIRT and > CONFIG_MCOUNT both enabled. Because CONFIG_MCOUNT disables > CONFIG_REGPARM, the calling convention must once again be explicit > with fastcall. However, this was only half-way address