Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-30 Thread Jason Low
On Sun, 2014-07-27 at 22:18 -0700, Davidlohr Bueso wrote: > ... as we clearly inline mcs_spin_lock() now. > > Signed-off-by: Davidlohr Bueso Acked-by: Jason Low -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Jason Low
On Mon, 2014-07-28 at 20:50 +0200, Peter Zijlstra wrote: > On Mon, Jul 28, 2014 at 10:49:35AM -0700, Jason Low wrote: > > > So if the function is inlined, perf report would show the contention > > occurring in the calling function rather than the inlined function. As > > an example, if we were to

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Peter Zijlstra
On Mon, Jul 28, 2014 at 10:49:35AM -0700, Jason Low wrote: > So if the function is inlined, perf report would show the contention > occurring in the calling function rather than the inlined function. As > an example, if we were to convert osq_lock() and mutex_spin_on_owner() > to inline, perf woul

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Jason Low
On Mon, 2014-07-28 at 18:54 +0200, Peter Zijlstra wrote: > On Mon, Jul 28, 2014 at 09:49:35AM -0700, Jason Low wrote: > > On Sun, 2014-07-27 at 22:18 -0700, Davidlohr Bueso wrote: > > > ... as we clearly inline mcs_spin_lock() now. > > > > > > Signed-off-by: Davidlohr Bueso > > > --- > > > kerne

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Jason Low
On Mon, 2014-07-28 at 18:57 +0200, Peter Zijlstra wrote: > On Mon, Jul 28, 2014 at 09:53:58AM -0700, Davidlohr Bueso wrote: > > Well, it's not hard to see where the contention is when working on > > locking issues with perf. With mutexes there are only two sources, > > either the task is just spinn

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Peter Zijlstra
On Mon, Jul 28, 2014 at 09:53:58AM -0700, Davidlohr Bueso wrote: > Well, it's not hard to see where the contention is when working on > locking issues with perf. With mutexes there are only two sources, > either the task is just spinning trying to get the lock, or its gone to > the slowpath, and yo

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Peter Zijlstra
On Mon, Jul 28, 2014 at 09:49:35AM -0700, Jason Low wrote: > On Sun, 2014-07-27 at 22:18 -0700, Davidlohr Bueso wrote: > > ... as we clearly inline mcs_spin_lock() now. > > > > Signed-off-by: Davidlohr Bueso > > --- > > kernel/locking/mcs_spinlock.h | 3 --- > > 1 file changed, 3 deletions(-) >

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Davidlohr Bueso
On Mon, 2014-07-28 at 09:49 -0700, Jason Low wrote: > On Sun, 2014-07-27 at 22:18 -0700, Davidlohr Bueso wrote: > > ... as we clearly inline mcs_spin_lock() now. > > > > Signed-off-by: Davidlohr Bueso > > --- > > kernel/locking/mcs_spinlock.h | 3 --- > > 1 file changed, 3 deletions(-) > > > >

Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment

2014-07-28 Thread Jason Low
On Sun, 2014-07-27 at 22:18 -0700, Davidlohr Bueso wrote: > ... as we clearly inline mcs_spin_lock() now. > > Signed-off-by: Davidlohr Bueso > --- > kernel/locking/mcs_spinlock.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/kernel/locking/mcs_spinlock.h b/kernel/locking/mcs_spinlo