Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-12-02 Thread Li, Aubrey
On 2020/12/2 22:09, Li, Aubrey wrote: > Hi Balbir, > > I still placed the patch embedded in this thread, welcome any comments. Sorry, this version needs more work, refined as below, and I realized I should place a version number to the patch, start from v2 now. Thanks, -Aubrey ==

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-12-02 Thread Li, Aubrey
Hi Balbir, I still placed the patch embedded in this thread, welcome any comments. Thanks, -Aubrey == >From d64455dcaf47329673903a68a9df1151400cdd7a Mon Sep 17 00:00:00 2001 From: Aubrey Li Date: Wed, 2 Dec 2020 13:53:30 +

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-30 Thread Li, Aubrey
On 2020/11/30 18:35, Vincent Guittot wrote: > On Wed, 18 Nov 2020 at 00:20, Joel Fernandes (Google) > wrote: >> >> From: Aubrey Li >> >> - Don't migrate if there is a cookie mismatch >> Load balance tries to move task from busiest CPU to the >> destination CPU. When core scheduling is

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-30 Thread Li, Aubrey
On 2020/11/30 17:33, Balbir Singh wrote: > On Thu, Nov 26, 2020 at 05:26:31PM +0800, Li, Aubrey wrote: >> On 2020/11/26 16:32, Balbir Singh wrote: >>> On Thu, Nov 26, 2020 at 11:20:41AM +0800, Li, Aubrey wrote: On 2020/11/26 6:57, Balbir Singh wrote: > On Wed, Nov 25, 2020 at 11:12:53AM +0

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-30 Thread Vincent Guittot
On Wed, 18 Nov 2020 at 00:20, Joel Fernandes (Google) wrote: > > From: Aubrey Li > > - Don't migrate if there is a cookie mismatch > Load balance tries to move task from busiest CPU to the > destination CPU. When core scheduling is enabled, if the > task's cookie does not match wi

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-30 Thread Balbir Singh
On Thu, Nov 26, 2020 at 05:26:31PM +0800, Li, Aubrey wrote: > On 2020/11/26 16:32, Balbir Singh wrote: > > On Thu, Nov 26, 2020 at 11:20:41AM +0800, Li, Aubrey wrote: > >> On 2020/11/26 6:57, Balbir Singh wrote: > >>> On Wed, Nov 25, 2020 at 11:12:53AM +0800, Li, Aubrey wrote: > On 2020/11/24

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-26 Thread Li, Aubrey
On 2020/11/26 16:32, Balbir Singh wrote: > On Thu, Nov 26, 2020 at 11:20:41AM +0800, Li, Aubrey wrote: >> On 2020/11/26 6:57, Balbir Singh wrote: >>> On Wed, Nov 25, 2020 at 11:12:53AM +0800, Li, Aubrey wrote: On 2020/11/24 23:42, Peter Zijlstra wrote: > On Mon, Nov 23, 2020 at 12:36:10PM

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-26 Thread Balbir Singh
On Thu, Nov 26, 2020 at 11:20:41AM +0800, Li, Aubrey wrote: > On 2020/11/26 6:57, Balbir Singh wrote: > > On Wed, Nov 25, 2020 at 11:12:53AM +0800, Li, Aubrey wrote: > >> On 2020/11/24 23:42, Peter Zijlstra wrote: > >>> On Mon, Nov 23, 2020 at 12:36:10PM +0800, Li, Aubrey wrote: > >> +#ifdef CO

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-25 Thread Li, Aubrey
On 2020/11/26 6:57, Balbir Singh wrote: > On Wed, Nov 25, 2020 at 11:12:53AM +0800, Li, Aubrey wrote: >> On 2020/11/24 23:42, Peter Zijlstra wrote: >>> On Mon, Nov 23, 2020 at 12:36:10PM +0800, Li, Aubrey wrote: >> +#ifdef CONFIG_SCHED_CORE >> +/* >> + *

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-25 Thread Balbir Singh
On Wed, Nov 25, 2020 at 11:12:53AM +0800, Li, Aubrey wrote: > On 2020/11/24 23:42, Peter Zijlstra wrote: > > On Mon, Nov 23, 2020 at 12:36:10PM +0800, Li, Aubrey wrote: > +#ifdef CONFIG_SCHED_CORE > +/* > + * Skip this cpu if source task's cookie does

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-24 Thread Li, Aubrey
On 2020/11/24 23:42, Peter Zijlstra wrote: > On Mon, Nov 23, 2020 at 12:36:10PM +0800, Li, Aubrey wrote: +#ifdef CONFIG_SCHED_CORE + /* + * Skip this cpu if source task's cookie does not match + * with CPU's core cookie. + */ +

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-24 Thread Peter Zijlstra
On Mon, Nov 23, 2020 at 12:36:10PM +0800, Li, Aubrey wrote: > >> +#ifdef CONFIG_SCHED_CORE > >> + /* > >> + * Skip this cpu if source task's cookie does not match > >> + * with CPU's core cookie. > >> + */ > >> + if (!sched_core_cookie_match(cpu_rq(cp

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-22 Thread Li, Aubrey
On 2020/11/23 7:54, Balbir Singh wrote: > On Tue, Nov 17, 2020 at 06:19:44PM -0500, Joel Fernandes (Google) wrote: >> From: Aubrey Li >> >> - Don't migrate if there is a cookie mismatch >> Load balance tries to move task from busiest CPU to the >> destination CPU. When core scheduling i

Re: [PATCH -tip 14/32] sched: migration changes for core scheduling

2020-11-22 Thread Balbir Singh
On Tue, Nov 17, 2020 at 06:19:44PM -0500, Joel Fernandes (Google) wrote: > From: Aubrey Li > > - Don't migrate if there is a cookie mismatch > Load balance tries to move task from busiest CPU to the > destination CPU. When core scheduling is enabled, if the > task's cookie does no