Re: [PATCH -v2] f2fs: Remove lock from check_valid_map

2014-09-09 Thread Huang Ying
On Tue, 2014-09-09 at 00:41 -0700, Jaegeuk Kim wrote: > On Tue, Sep 09, 2014 at 01:43:46PM +0800, Huang Ying wrote: > > On Mon, 2014-09-08 at 22:13 -0700, Jaegeuk Kim wrote: > > > Hi Huang, > > > > > > On Mon, Sep 08, 2014 at 03:36:35PM +0800, huang ying wrote: > > > > Hi, Jaegeuk, > > > > > > >

Re: [PATCH -v2] f2fs: Remove lock from check_valid_map

2014-09-09 Thread Jaegeuk Kim
On Tue, Sep 09, 2014 at 01:43:46PM +0800, Huang Ying wrote: > On Mon, 2014-09-08 at 22:13 -0700, Jaegeuk Kim wrote: > > Hi Huang, > > > > On Mon, Sep 08, 2014 at 03:36:35PM +0800, huang ying wrote: > > > Hi, Jaegeuk, > > > > > > On Mon, Sep 8, 2014 at 11:50 AM, Jaegeuk Kim wrote: > > > > > > >

Re: [PATCH -v2] f2fs: Remove lock from check_valid_map

2014-09-08 Thread Huang Ying
On Mon, 2014-09-08 at 22:13 -0700, Jaegeuk Kim wrote: > Hi Huang, > > On Mon, Sep 08, 2014 at 03:36:35PM +0800, huang ying wrote: > > Hi, Jaegeuk, > > > > On Mon, Sep 8, 2014 at 11:50 AM, Jaegeuk Kim wrote: > > > > > Hi, > > > > > > On Sun, Sep 07, 2014 at 11:38:30AM +0800, Huang Ying wrote: >

Re: [PATCH -v2] f2fs: Remove lock from check_valid_map

2014-09-08 Thread Jaegeuk Kim
Hi Huang, On Mon, Sep 08, 2014 at 03:36:35PM +0800, huang ying wrote: > Hi, Jaegeuk, > > On Mon, Sep 8, 2014 at 11:50 AM, Jaegeuk Kim wrote: > > > Hi, > > > > On Sun, Sep 07, 2014 at 11:38:30AM +0800, Huang Ying wrote: > > > Only one bit is read in check_valid_map, holding a lock to do that > >

Re: [PATCH -v2] f2fs: Remove lock from check_valid_map

2014-09-07 Thread Jaegeuk Kim
Hi, On Sun, Sep 07, 2014 at 11:38:30AM +0800, Huang Ying wrote: > Only one bit is read in check_valid_map, holding a lock to do that > doesn't help anything except decreasing performance. > > Signed-off-by: Huang, Ying > --- > > v2: Fixed a build warning. > > --- > fs/f2fs/gc.c |3 --- >