Re: [PATCH -v2 09/26] infiniband: rename random32() to prandom_u32()

2013-01-05 Thread Steve Wise
Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH -v2 09/26] infiniband: rename random32() to prandom_u32()

2013-01-05 Thread Steve Wise
On 1/5/2013 7:37 AM, Akinobu Mita wrote: 2013/1/5 Steve Wise : I'm asking: why are you bothering with renaming the functions? This seems like a needless change, _unless_ there are really non-pseudo-random services being added. We already have get_random_byte() which is not pseudo-random number

Re: [PATCH -v2 09/26] infiniband: rename random32() to prandom_u32()

2013-01-05 Thread Akinobu Mita
2013/1/5 Steve Wise : > I'm asking: why are you bothering with renaming the functions? This seems > like a needless change, _unless_ there are really non-pseudo-random services > being added. We already have get_random_byte() which is not pseudo-random number generator. Apart from that, the nami

Re: [PATCH -v2 09/26] infiniband: rename random32() to prandom_u32()

2013-01-04 Thread Steve Wise
I'm asking: why are you bothering with renaming the functions? This seems like a needless change, _unless_ there are really non-pseudo-random services being added. On 1/4/2013 7:45 AM, Akinobu Mita wrote: 2013/1/4 Steve Wise : Are there other "non pseudo-random" services that warrant this re

Re: [PATCH -v2 09/26] infiniband: rename random32() to prandom_u32()

2013-01-04 Thread Akinobu Mita
2013/1/4 Steve Wise : > Are there other "non pseudo-random" services that warrant this rename? I couldn't understand your question very well. So I'm not sure this is the expected answer: I only renamed pseudo-random functions defined in lib/random32.c in the commit 496f2f93 ("random32: rename ran

Re: [PATCH -v2 09/26] infiniband: rename random32() to prandom_u32()

2013-01-03 Thread Steve Wise
Are there other "non pseudo-random" services that warrant this rename? On 1/3/2013 6:19 AM, Akinobu Mita wrote: Use more preferable function name which implies using a pseudo-random number generator. Signed-off-by: Akinobu Mita Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock Cc: Steve W