Re: [PATCH 0/13] remove cli()/sti() in drivers/char/*

2005-01-16 Thread Jim Nelson
Alan Cox wrote: On Sul, 2005-01-16 at 21:04, Andrew Morton wrote: James Nelson <[EMAIL PROTECTED]> wrote: This series of patches removes the last cli()/sti()/save_flags()/restore_flags() function calls in drivers/char. I don't see much point in this, really. Those cli() calls are a big fat sign sa

Re: [PATCH 0/13] remove cli()/sti() in drivers/char/*

2005-01-16 Thread Alan Cox
On Sul, 2005-01-16 at 21:04, Andrew Morton wrote: > James Nelson <[EMAIL PROTECTED]> wrote: > > > > This series of patches removes the last > > cli()/sti()/save_flags()/restore_flags() > > function calls in drivers/char. > > I don't see much point in this, really. Those cli() calls are a big fa

Re: [PATCH 0/13] remove cli()/sti() in drivers/char/*

2005-01-16 Thread Andrew Morton
James Nelson <[EMAIL PROTECTED]> wrote: > > This series of patches removes the last > cli()/sti()/save_flags()/restore_flags() > function calls in drivers/char. I don't see much point in this, really. Those cli() calls are a big fat sign saying "broken on smp" and they now generate compile-time

Re: [PATCH 0/13] remove cli()/sti() in drivers/char/*

2005-01-16 Thread Jim Nelson
Randy.Dunlap wrote: James Nelson wrote: This series of patches removes the last cli()/sti()/save_flags()/restore_flags() function calls in drivers/char. to what end? I guess I don't get it. What makes these drivers SMP-safe now? Or is this series of patches only done to kill off the use of depre

Re: [PATCH 0/13] remove cli()/sti() in drivers/char/*

2005-01-16 Thread Randy.Dunlap
James Nelson wrote: This series of patches removes the last cli()/sti()/save_flags()/restore_flags() function calls in drivers/char. to what end? I guess I don't get it. What makes these drivers SMP-safe now? Or is this series of patches only done to kill off the use of deprecated functions? If t