Re: [PATCH 0/18] net: dsa: HW bridging, EEE support

2015-03-21 Thread Guenter Roeck
On 03/21/2015 07:14 PM, David Miller wrote: From: Guenter Roeck Date: Sat, 21 Mar 2015 16:12:30 -0700 Yes, agreed. It is on the to-do list. Should we be more aggressive ? Since I'll have to resubmit anyway, we could start by adding defines for all constants used in this patch set, not just som

Re: [PATCH 0/18] net: dsa: HW bridging, EEE support

2015-03-21 Thread David Miller
From: Guenter Roeck Date: Sat, 21 Mar 2015 16:12:30 -0700 > Yes, agreed. It is on the to-do list. Should we be more aggressive ? > Since I'll have to resubmit anyway, we could start by adding defines > for all constants used in this patch set, not just some of them. As long as you'll really take

Re: [PATCH 0/18] net: dsa: HW bridging, EEE support

2015-03-21 Thread Andrew Lunn
> >But this driver would be so much easier to read and understand if it > >used mnemonics instead of constants for the register offsets. > > > > Yes, agreed. It is on the to-do list. Should we be more aggressive ? > Since I'll have to resubmit anyway, we could start by adding defines > for all con

Re: [PATCH 0/18] net: dsa: HW bridging, EEE support

2015-03-21 Thread Guenter Roeck
On 03/21/2015 03:48 PM, David Miller wrote: From: Guenter Roeck Date: Sat, 21 Mar 2015 08:46:37 -0700 Patch 1 to 7 of this series prepare the drivers using the mv88e6xxx code for HW bridging support, without adding the code itself. For the most part this factors out common port initialization

Re: [PATCH 0/18] net: dsa: HW bridging, EEE support

2015-03-21 Thread David Miller
From: Guenter Roeck Date: Sat, 21 Mar 2015 08:46:37 -0700 > Patch 1 to 7 of this series prepare the drivers using the mv88e6xxx code > for HW bridging support, without adding the code itself. For the most part > this factors out common port initialization code. There is no functional > change exc