Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles

2013-04-09 Thread Vyacheslav Dubeyko
On Tue, 2013-04-09 at 03:39 -0700, Joe Perches wrote: > On Tue, 2013-04-09 at 11:08 +0400, Vyacheslav Dubeyko wrote: > > On Mon, 2013-04-08 at 09:37 -0700, Joe Perches wrote: > > > Joe Perches (2): > > > hfs/hfsplus: Convert dprint to hfs_dbg > > > hfs/hfsplus: Convert printks to pr_ > [] > > B

Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles

2013-04-09 Thread Joe Perches
On Tue, 2013-04-09 at 11:08 +0400, Vyacheslav Dubeyko wrote: > On Mon, 2013-04-08 at 09:37 -0700, Joe Perches wrote: > > Joe Perches (2): > > hfs/hfsplus: Convert dprint to hfs_dbg > > hfs/hfsplus: Convert printks to pr_ [] > But I have some additional suggestions: > (1) I think that it makes s

Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles

2013-04-09 Thread Vyacheslav Dubeyko
On Mon, 2013-04-08 at 09:37 -0700, Joe Perches wrote: > Joe Perches (2): > hfs/hfsplus: Convert dprint to hfs_dbg > hfs/hfsplus: Convert printks to pr_ > Thank you for your efforts. It is a good work. But I have some additional suggestions: (1) I think that it makes sense to use no_printk()