Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-13 Thread Miguel Ojeda
On Sat, Feb 9, 2019 at 9:33 PM Laura Abbott wrote: > > Tested-by: Laura Abbott > > You can look at the full build logs at > https://koji.fedoraproject.org/koji/taskinfo?taskID=326911 . > > Thanks, > Laura Thanks a lot for the tests, Laura! I will send this for -rc7. Cheers, Miguel

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-11 Thread Ard Biesheuvel
On Mon, 11 Feb 2019 at 17:21, Martin Sebor wrote: > > On 2/9/19 5:31 AM, Miguel Ojeda wrote: > > On Sat, Feb 9, 2019 at 12:26 PM Ard Biesheuvel > > wrote: > >> > >> On Sat, 9 Feb 2019 at 12:19, Miguel Ojeda > >> wrote: > >>> > >>> It also affects the optimizer in two different ways AFAIK: > >>>

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-11 Thread Martin Sebor
On 2/9/19 5:31 AM, Miguel Ojeda wrote: On Sat, Feb 9, 2019 at 12:26 PM Ard Biesheuvel wrote: On Sat, 9 Feb 2019 at 12:19, Miguel Ojeda wrote: It also affects the optimizer in two different ways AFAIK: * For the function itself, it gets optimized for size instead of speed. * For calle

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-09 Thread Laura Abbott
On 2/9/19 12:08 AM, Miguel Ojeda wrote: The upcoming GCC 9 release extends the -Wmissing-attributes warnings (enabled by -Wall) to C and aliases: it warns when particular function attributes are missing in the aliases but not in their target, e.g.: void __cold f(void) {} void __alias("

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-09 Thread Miguel Ojeda
On Sat, Feb 9, 2019 at 12:26 PM Ard Biesheuvel wrote: > > On Sat, 9 Feb 2019 at 12:19, Miguel Ojeda > wrote: > > > > It also affects the optimizer in two different ways AFAIK: > > > > * For the function itself, it gets optimized for size instead of speed. > > * For callers, the paths that lea

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-09 Thread Ard Biesheuvel
On Sat, 9 Feb 2019 at 12:19, Miguel Ojeda wrote: > > On Sat, Feb 9, 2019 at 11:44 AM Ard Biesheuvel > wrote: > > > > On Sat, 9 Feb 2019 at 01:09, Miguel Ojeda > > wrote: > > > > > > The upcoming GCC 9 release extends the -Wmissing-attributes warnings > > > (enabled by -Wall) to C and aliases: it

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-09 Thread Miguel Ojeda
On Sat, Feb 9, 2019 at 11:44 AM Ard Biesheuvel wrote: > > On Sat, 9 Feb 2019 at 01:09, Miguel Ojeda > wrote: > > > > The upcoming GCC 9 release extends the -Wmissing-attributes warnings > > (enabled by -Wall) to C and aliases: it warns when particular function > > attributes are missing in the al

Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

2019-02-09 Thread Ard Biesheuvel
On Sat, 9 Feb 2019 at 01:09, Miguel Ojeda wrote: > > The upcoming GCC 9 release extends the -Wmissing-attributes warnings > (enabled by -Wall) to C and aliases: it warns when particular function > attributes are missing in the aliases but not in their target, e.g.: > > void __cold f(void) {}