Re: [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics

2015-08-22 Thread George Spelvin
Ingo Molnar wrote: > I think this is too complex. > > How about something simple like the patch below (on top of the third patch)? > It makes the vmalloc info transactional - /proc/meminfo will always print a > consistent set of numbers. (Not that we really care about races there, but it > loo

Re: [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics

2015-08-22 Thread Ingo Molnar
* George Spelvin wrote: > Linus wrote: > > I don't think any of this can be called "correct", in that the > > unlocked accesses to the cached state are clearly racy, but I think > > it's very much "acceptable". > > I'd think you could easily fix that with a seqlock-like system. > > What makes

Re: [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics

2015-08-22 Thread George Spelvin
Linus wrote: > I don't think any of this can be called "correct", in that the > unlocked accesses to the cached state are clearly racy, but I think > it's very much "acceptable". I'd think you could easily fix that with a seqlock-like system. What makes it so simple is that you can always fall ba

Re: [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics

2015-08-22 Thread Linus Torvalds
On Sat, Aug 22, 2015 at 3:44 AM, Ingo Molnar wrote: > > Would something like this be acceptable (and is it correct)? I don't think any of this can be called "correct", in that the unlocked accesses to the cached state are clearly racy, but I think it's very much "acceptable".