Re: [PATCH 0/4] Improve CLKSRC_OF matching

2013-02-08 Thread Rob Herring
On 02/07/2013 10:51 PM, Tony Prisk wrote: > On Thu, 2013-02-07 at 13:09 -0600, Rob Herring wrote: >> From: Rob Herring >> >> In the recently added support for OF based clocksource init, a device node >> will be matched twice. We can fix this by passing the device node to the >> init functions and

Re: [PATCH 0/4] Improve CLKSRC_OF matching

2013-02-07 Thread Tony Prisk
On Thu, 2013-02-07 at 13:09 -0600, Rob Herring wrote: > From: Rob Herring > > In the recently added support for OF based clocksource init, a device node > will be matched twice. We can fix this by passing the device node to the > init functions and removing the match functions within the init fun

Re: [PATCH 0/4] Improve CLKSRC_OF matching

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Rob Herring wrote: > How so? I don't see a warning as there is no type checking on the init > function since of_device_id.data is just a void *. It would be good to > have type checking here if you know a way, but I don't. Ah, that's right. So it silently builds find

Re: [PATCH 0/4] Improve CLKSRC_OF matching

2013-02-07 Thread Rob Herring
On 02/07/2013 04:44 PM, Arnd Bergmann wrote: > On Thursday 07 February 2013, Rob Herring wrote: >> From: Rob Herring >> >> In the recently added support for OF based clocksource init, a device node >> will be matched twice. We can fix this by passing the device node to the >> init functions and re

Re: [PATCH 0/4] Improve CLKSRC_OF matching

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Rob Herring wrote: > From: Rob Herring > > In the recently added support for OF based clocksource init, a device node > will be matched twice. We can fix this by passing the device node to the > init functions and removing the match functions within the init function